Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate status check in CFE_EVS_EnableAppEventTypeCmd #1450

Open
skliper opened this issue Apr 29, 2021 · 0 comments · May be fixed by #2185
Open

Remove duplicate status check in CFE_EVS_EnableAppEventTypeCmd #1450

skliper opened this issue Apr 29, 2021 · 0 comments · May be fixed by #2185

Comments

@skliper
Copy link
Contributor

skliper commented Apr 29, 2021

Is your feature request related to a problem? Please describe.
Checking for status and outputing command handler debug event here:

if (Status == CFE_SUCCESS)
{
EVS_SendEvent(CFE_EVS_ENAAPPEVTTYPE_EID, CFE_EVS_EventType_DEBUG,
"Enable App Event Type Command Received with AppName = %s, EventType Bit Mask = 0x%02x",
LocalName, CmdPtr->BitMask);
}

Could output event within the first check here:

else
{
EVS_EnableTypes(AppDataPtr, CmdPtr->BitMask);
}

Describe the solution you'd like
Move event.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant