Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CFE_MSG_SequenceCount_t for seqcnt in CFE_SBR_GetSequenceCounter #1476

Closed
skliper opened this issue May 3, 2021 · 1 comment · Fixed by #1564 or #1584
Closed

Use CFE_MSG_SequenceCount_t for seqcnt in CFE_SBR_GetSequenceCounter #1476

skliper opened this issue May 3, 2021 · 1 comment · Fixed by #1564 or #1584
Labels
cFE-SBR CFS-42 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented May 3, 2021

Is your feature request related to a problem? Please describe.
Not using CFE_MSG_SequenceCount_t:

cFE/modules/sbr/fsw/src/cfe_sbr_route_unsorted.c

Line 172 in c8b5e00

uint32 seqcnt = 0;

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone May 3, 2021
@skliper skliper mentioned this issue May 3, 2021
Closed
@skliper
Copy link
Contributor Author

skliper commented May 17, 2021

Ping @pepepr08

skliper added a commit to skliper/cFE that referenced this issue May 21, 2021
@skliper
Fix nasa#1476, Use CFE_MSG_SequenceCount_t for seqcnt type
6333d25
@skliper skliper mentioned this issue May 21, 2021
Merged
astrogeco added a commit that referenced this issue May 27, 2021
@astrogeco
Merge pull request #1564 from skliper/fix1476-sequencecounttype
b1f36ee 
Fix #1476, Use CFE_MSG_SequenceCount_t for seqcnt type
@astrogeco astrogeco mentioned this issue Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cFE-SBR CFS-42 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco