Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name of macros/functions added to "cfe_assert" #1835

Closed
jphickey opened this issue Aug 17, 2021 · 1 comment · Fixed by #1948 or #1967
Closed

Update name of macros/functions added to "cfe_assert" #1835

jphickey opened this issue Aug 17, 2021 · 1 comment · Fixed by #1948 or #1967
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Per the naming convention, any symbols provided by a given app/lib should be prefixed with the name of that module. For "cfe_assert" library, this would be CFE_Assert_ prefix. But the new macros that were directly lifted from the coverage test are using a CFE_UtAssert_ prefix.

Describe the solution you'd like
Search and replace the CFE_UtAssert_ prefix with CFE_Assert_ to be consistent.

Additional context
This came from migrating the macros in haste; the extra "Ut" that doesn't really belong wasn't caught during initial implementation or review.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 17, 2021
@jphickey
Copy link
Contributor Author

Although this is trivial/automated to do, need to wait until outstanding PRs are merged first (otherwise conflicts).

jphickey added a commit to jphickey/cFE that referenced this issue Sep 13, 2021
@jphickey
Fix nasa#1835, CFE_Assert macro names
06a293b 
Replace "CFE_UtAssert" macro prefix with "CFE_Assert", to match
the naming convention.  (The "UtAssert" was a carry over from
the coverage test environment).
@jphickey jphickey mentioned this issue Sep 13, 2021
Merged
astrogeco added a commit that referenced this issue Sep 16, 2021
@astrogeco
Merge pull request #1948 from jphickey/fix-1835-cfe-assert-macronames
bb936ef 
Fix #1835, CFE_Assert macro names
@astrogeco astrogeco mentioned this issue Sep 21, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #1835, CFE_Assert macro names jphickey/cFE
cFE Integration candidate: 2021-09-21 nasa/cFE
2 participants
@jphickey @skliper