Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_TBL_ERR_FILE_NOT_FOUND error defined but not used #1858

Closed
jphickey opened this issue Aug 20, 2021 · 0 comments · Fixed by #1859 or #1839
Closed

CFE_TBL_ERR_FILE_NOT_FOUND error defined but not used #1858

jphickey opened this issue Aug 20, 2021 · 0 comments · Fixed by #1859 or #1839
Assignees
@jphickey
Labels
deprecate enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is documented as a return code from CFE_TBL_Load however this function actually returns CFE_TBL_ERR_ACCESS when it cannot open the file. This "file not found" status code is not used- and it cannot be used - because OS_OpenCreate does not really differentiate between the file not existing and existing but not having permission to open it.

Describe the solution you'd like
Remove unused status code

Additional context
Found as part of scrub in #1724

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 20, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 20, 2021
@jphickey
Fix nasa#1858, remove unused CFE_TBL_ERR_FILE_NOT_FOUND
0986a60 
Status code no longer produced by current implementation, it
returns CFE_TBL_ERR_ACCESS when unable to open a file.
@jphickey jphickey mentioned this issue Aug 20, 2021
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Aug 20, 2021
@jphickey
Fix nasa#1858, remove unused CFE_TBL_ERR_FILE_NOT_FOUND
5f6aaf8 
Status code no longer produced by current implementation, it
returns CFE_TBL_ERR_ACCESS when unable to open a file.
astrogeco added a commit that referenced this issue Aug 20, 2021
@astrogeco
Merge pull request #1859 from jphickey/fix-1858-tbl-filenotfound-err
c729862 
Fix #1858, remove unused CFE_TBL_ERR_FILE_NOT_FOUND

Fix #1863, Remove comment referencing CFE_TBL_ERR_FILE_NOT_FOUND
@astrogeco astrogeco mentioned this issue Aug 20, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
deprecate enhancement
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco