Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TIME tests to use bitmask check macros #1912

Closed
jphickey opened this issue Aug 30, 2021 · 0 comments · Fixed by #1885
Closed

Update TIME tests to use bitmask check macros #1912

jphickey opened this issue Aug 30, 2021 · 0 comments · Fixed by #1885
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
With nasa/osal#1136, UtAssert now provides a better macro for testing bit fields/masks. The updated macro provides better/more concise information in the test log.

Describe the solution you'd like
Replace the UtAssert_UINT32_EQ checks with the new macros - UtAssert_BITMASK_SET/UtAssert_BITMASK_UNSET.

Additional context
Depends on nasa/osal#1136 and #1860 (both currently in IC but not in main, as of this writing).

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 30, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 30, 2021
@jphickey
Fix nasa#1912, Update time tests to use bitmask check macros
cf2ebfa 
Replace UtAssert_UINT32_EQ with bitmask-specific check macros
jphickey added a commit to jphickey/cFE that referenced this issue Aug 30, 2021
@jphickey
Fix nasa#1912, Update time tests to use bitmask check macros
7b83bed 
Replace UtAssert_UINT32_EQ with bitmask-specific check macros
astrogeco added a commit that referenced this issue Sep 1, 2021
@astrogeco
Merge pull request #1913 from jphickey/fix-1912-bitmask-checks
6aa555a 
Fix #1912, Update time tests to use bitmask check macros
@astrogeco astrogeco mentioned this issue Sep 1, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

cFE Integration candidate: 2021-08-31 nasa/cFE
2 participants
@jphickey @skliper