Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment about MISSION_GLOBAL_APPLIST is confusing #1918

Closed
asgibson opened this issue Aug 31, 2021 · 1 comment · Fixed by #1923
Closed

Comment about MISSION_GLOBAL_APPLIST is confusing #1918

asgibson opened this issue Aug 31, 2021 · 1 comment · Fixed by #1923
Assignees
Labels
docs This change only affects documentation. question
Milestone

Comments

@asgibson
Copy link
Contributor

Describe the bug
The first sentence for the description of MISSION_GLOBAL_APPLIST in cFE/cmake/sample_defs/targets.cmake does not make sense. 'The "MISSION_GLOBAL_APPLIST" is a set of apps/libs that will be built for every defined and target.' Specifically 'defined and target' does not provide clarity as to the intent here. Removing the 'and' would have it make sense, but was something else meant to be imparted here?

To Reproduce
N/A

Expected behavior
N/A

Code snips

# The "MISSION_GLOBAL_APPLIST" is a set of apps/libs that will be built
# for every defined and target. These are built as dynamic modules

System observed on:
N/A

Additional context
N/A

Reporter Info
Alan Gibson
NASA GSFC/587

@asgibson asgibson added question docs This change only affects documentation. labels Aug 31, 2021
@jphickey
Copy link
Contributor

Thanks for catching. Confirmed - just need to remove the word "and" here.

@jphickey jphickey self-assigned this Aug 31, 2021
@skliper skliper added this to the 7.0.0 milestone Aug 31, 2021
astrogeco added a commit that referenced this issue Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change only affects documentation. question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants