Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unary minus operator should not be applied to an unsigned expression #2150

Closed
ArielSAdamsNASA opened this issue Sep 23, 2022 · 0 comments · Fixed by #2437
Closed

Unary minus operator should not be applied to an unsigned expression #2150

ArielSAdamsNASA opened this issue Sep 23, 2022 · 0 comments · Fixed by #2437
Labels
enhancement

Comments

@ArielSAdamsNASA
Copy link

Describe the bug
Negation of unsigned value

Expected behavior
Keep same behavior but fix CodeQL warning.

Code snips

cFE/modules/evs/fsw/src/cfe_evs_utils.c

Line 319 in 9f42688

const int32 LOWER_THRESHOLD = -CFE_EVS_Global.EVS_EventBurstMax * 1000;

Additional context
Caught by CodeQL - Violation of MISRA (Part of the coding standard). Could cast EVS_EventBurstMax.

Reporter Info
Ariel Adams, MCSG Tech
@chillfig chillfig mentioned this issue Sep 7, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Sep 13, 2023
@dzbaker
Merge pull request #2437 from chillfig:cast_EventBurstMax
db8ffb2 
Fix #2150, Adds a cast to the negation of unsigned expression
@dzbaker dzbaker mentioned this issue Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2150, Adds a cast to the negation of unsigned expression chillfig/cFE
2 participants
@chillfig @ArielSAdamsNASA