Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1450, Remove duplicate status check #2185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 25, 2022

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No impact on behavior.
Logic does not change as the event is still sent in first if (Status == CFE_SUCCESS).

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1450-remove-duplicate-status-check branch from 69c981c to 0e88250 Compare January 23, 2023 23:03
@thnkslprpt
Copy link
Contributor Author

Noticed second case of the same issue (redundant repeat status check) and added to this PR with a second commit (and squashed them).

@thnkslprpt thnkslprpt force-pushed the fix-1450-remove-duplicate-status-check branch from 0e88250 to 5f746e9 Compare April 19, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate status check in CFE_EVS_EnableAppEventTypeCmd
1 participant