Move calls to CFE_ES_GetAppName() to reduce code duplication in CFE_TBL_Register()

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
These 3 calls to CFE_ES_GetAppName() in CFE_TBL_Register() could be reduced to 1 if it was moved up a bit higher.

Code snips

cFE/modules/tbl/fsw/src/cfe_tbl_api.c

Lines 366 to 422 in 7af467e

	CFE_ES_GetAppName(AppName, ThisAppId, sizeof(AppName));
	CFE_ES_WriteToSysLog("%s: Failed to get work buffer for '%s.%s' (ErrCode=0x%08X)\n",
	__func__, AppName, Name, (unsigned int)Status);
	}
	else
	{
	/* CDS exists for this table - try to restore the data */
	Status = CFE_ES_RestoreFromCDS(WorkingBufferPtr->BufferPtr, RegRecPtr->CDSHandle);
	if (Status != CFE_SUCCESS)
	{
	CFE_ES_GetAppName(AppName, ThisAppId, sizeof(AppName));
	CFE_ES_WriteToSysLog("%s: Failed to recover '%s.%s' from CDS (ErrCode=0x%08X)\n",
	__func__, AppName, Name, (unsigned int)Status);
	}
	}
	if (Status != CFE_SUCCESS)
	{
	/* Treat a restore from existing CDS error the same as */
	/* after a power-on reset (CDS was created but is empty) */
	Status = CFE_SUCCESS;
	}
	else
	{
	/* Try to locate the associated information in the Critical Table Registry */
	CFE_TBL_FindCriticalTblInfo(&CritRegRecPtr, RegRecPtr->CDSHandle);
	if ((CritRegRecPtr != NULL) && (CritRegRecPtr->TableLoadedOnce))
	{
	strncpy(WorkingBufferPtr->DataSource, CritRegRecPtr->LastFileLoaded,
	sizeof(WorkingBufferPtr->DataSource) - 1);
	WorkingBufferPtr->DataSource[sizeof(WorkingBufferPtr->DataSource) - 1] = '\0';
	WorkingBufferPtr->FileCreateTimeSecs = CritRegRecPtr->FileCreateTimeSecs;
	WorkingBufferPtr->FileCreateTimeSubSecs = CritRegRecPtr->FileCreateTimeSubSecs;
	strncpy(RegRecPtr->LastFileLoaded, CritRegRecPtr->LastFileLoaded,
	sizeof(RegRecPtr->LastFileLoaded) - 1);
	RegRecPtr->LastFileLoaded[sizeof(RegRecPtr->LastFileLoaded) - 1] = '\0';
	RegRecPtr->TimeOfLastUpdate.Seconds = CritRegRecPtr->TimeOfLastUpdate.Seconds;
	RegRecPtr->TimeOfLastUpdate.Subseconds = CritRegRecPtr->TimeOfLastUpdate.Subseconds;
	RegRecPtr->TableLoadedOnce = CritRegRecPtr->TableLoadedOnce;
	/* Compute the CRC on the specified table buffer */
	WorkingBufferPtr->Crc = CFE_ES_CalculateCRC(
	WorkingBufferPtr->BufferPtr, RegRecPtr->Size, 0, CFE_MISSION_ES_DEFAULT_CRC);
	/* Make sure everyone who sees the table knows that it has been updated */
	CFE_TBL_NotifyTblUsersOfUpdate(RegRecPtr);
	/* Make sure the caller realizes the contents have been initialized */
	Status = CFE_TBL_INFO_RECOVERED_TBL;
	}
	else
	{
	/* If an error occurred while trying to get the previous contents registry info, */
	/* Log the error in the System Log and pretend like we created a new CDS */
	CFE_ES_GetAppName(AppName, ThisAppId, sizeof(AppName));

Expected behavior
Reduce unnecessary code duplication.

Reporter Info
Avi Weiss @thnkslprpt