Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untraced feature to decompress apps/lib on load #399

Closed
skliper opened this issue Nov 7, 2019 · 2 comments · Fixed by #638 or #692
Closed

Untraced feature to decompress apps/lib on load #399

skliper opened this issue Nov 7, 2019 · 2 comments · Fixed by #638 or #692
Assignees
@skliper
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Nov 7, 2019

Describe the uncovered feature
The feature to decompress apps/libraries on load that end in .gz does not have requirements or associated build verification. Note it is covered in coverage/functional testing in fs_UT.c.

Possible solutions

  1. Remove this feature from the core (allows FS - externalize cfe_fs_decompress #291 to externalize decompress to be implemented cleanly)
  2. Add requirements, design, and build verification and resolve how to implement vs FS - externalize cfe_fs_decompress #291 desire to externalize

Related software

  • Implemented in cfe_es_apps.c
  • Utilizes cfe_fs_api.c: CFE_FS_IsGzFile, CFE_FS_GetUncompressedFile, cfe_fs_decompress.c and cfe_fs_decompress.h

Additional concern
CFE_FS_Decompress prototype is defined in both inc/cfe_fs.h and cfe_fs_decompress.h

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper
Copy link
Contributor Author

skliper commented Nov 13, 2019

CCB 20191113 - Discussed and concurred with removal. JSC checking for dependencies.

Other approaches - could use compressed file system (linux functionality), or can decompress using FM then load app/lib using ES. No use case identified that requires this functionality be built into ES.

@skliper
Copy link
Contributor Author

skliper commented Jan 28, 2020

See also discussion on #407 covering alternate, more efficient/effective methods that reduces complexity in cFE (decompress at boot/prior to cFE startup).

@skliper skliper added this to the 6.8.0 milestone Feb 7, 2020
@skliper skliper mentioned this issue Feb 11, 2020
Merged
@skliper skliper mentioned this issue Feb 26, 2020
Closed
@skliper skliper self-assigned this Apr 24, 2020
skliper added a commit to skliper/cFE that referenced this issue Apr 24, 2020
@skliper
Fix nasa#399, Deprecate decompress
954ba6b 
Removes untraced capabilities to decompress libraries or
apps on load.  For non-startup apps, FS can be used.  For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.

Also fixes nasa#291, by deprecating decompress it can be moved
to the FS app.

Also makes nasa#135 N/A, static code analysis issues in decompress
@skliper skliper mentioned this issue Apr 24, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Apr 24, 2020
@skliper
Fix nasa#399, Deprecate decompress
9b6278c 
Removes untraced capabilities to decompress libraries or
apps on load.  For non-startup apps, FS can be used.  For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.

Also fixes nasa#291, by deprecating decompress it can be moved
to the FS app.

Also makes nasa#135 N/A, static code analysis issues in decompress
skliper added a commit to skliper/cFE that referenced this issue Apr 28, 2020
@skliper
Fix nasa#399, Deprecate decompress
fec76a6 
Removes untraced capabilities to decompress libraries or
apps on load.  For non-startup apps, FS can be used.  For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.

Also fixes nasa#291, by deprecating decompress it can be moved
to the FS app.

Also makes nasa#135 N/A, static code analysis issues in decompress
skliper added a commit to skliper/cFE that referenced this issue May 8, 2020
@skliper
Fix nasa#399, Deprecate decompress
56e024c 
Removes untraced capabilities to decompress libraries or
apps on load.  For non-startup apps, FS can be used.  For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.

Also fixes nasa#291, by deprecating decompress it can be moved
to the FS app.

Also makes nasa#135 N/A, static code analysis issues in decompress
astrogeco added a commit that referenced this issue May 8, 2020
@astrogeco
Merge pull request #638 from skliper/fix399-decompress-untraced
d4d9130 
Fix #399, Deprecate decompress
skliper added a commit to skliper/cFE that referenced this issue May 11, 2020
@skliper
Merge pull request nasa#638 from skliper/fix399-decompress-untraced
4102f47 
Fix nasa#399, Deprecate decompress
@astrogeco astrogeco mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement
Projects
None yet
Milestone
Bootes
1 participant
@skliper