Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ut_sb_stubs.c needs a stub for CFE_SB_ZeroCopyGetPtr #702

Closed
asgibson opened this issue May 14, 2020 · 6 comments · Fixed by #763
Closed

ut_sb_stubs.c needs a stub for CFE_SB_ZeroCopyGetPtr #702

asgibson opened this issue May 14, 2020 · 6 comments · Fixed by #763
Assignees
Milestone

Comments

@asgibson
Copy link
Contributor

Is your feature request related to a problem? Please describe.
CFE_SB_ZeroCopyGetPtr does not have a stub in ut_sb_stubs.c causing undefined reference error when building unit tests for an app that uses this call.

Describe the solution you'd like
Add the stub for CFE_SB_ZeroCopyGetPtr with full context tracking.

Describe alternatives you've considered
Create my own locally in the app's unit test, but this does not help everyone.

Requester Info
Alan Gibson, NASA

@skliper skliper added this to the 6.8.0 milestone May 14, 2020
@skliper
Copy link
Contributor

skliper commented May 14, 2020

Contribute your implementation?

@jphickey
Copy link
Contributor

Probably don't need an individual issue ticket for each missing stub though.... maybe just one issue to scrub the public API and make sure we have a stub for each one?

@asgibson
Copy link
Contributor Author

I had considered that. That seems less targeted and more likely to take extra time, whereas these are the ones I currently need, but if you really want that I will close these and create a general issue.

@astrogeco
Copy link
Contributor

I think it's fine to have small issues. And I think it should be a best practice.

@jphickey
Copy link
Contributor

Either way is fine but we probably should have a to-do item to scrub the public API for missing stubs, in case one was overlooked elsewhere.

@skliper skliper modified the milestones: 6.8.0, 7.0.0 Jun 5, 2020
@zanzaben
Copy link
Contributor

zanzaben commented Mar 1, 2021

fixed by #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants