Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #762, scrub of all CFE UT stub functions #763

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Jun 26, 2020

Describe the contribution

Scrubs all CFE unit test functions to ensure that:

  1. All functions in the CFE public API have a stub function implemented
  2. All parameters to the stub function are registered in the context object,
    so the values will be available to hook functions.
  3. The names of all parameters match the prototype/documentation, so hook
    functions that use name-based argument value retrieval will work.

Fix #762
Fix #702

Testing performed
Build and run all CFE unit tests
Sanity check on CFE execution (but this doesn't change any FSW code).

Expected behavior changes
No impact to current behavior - except it does change the internal names of some stub arguments to match prototype.
Note this only changes UT stubs.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

CDKnightNASA and others added 9 commits June 5, 2020 12:37
* Fix nasa#604, Add a reference to cFE User's Guide to cFE README.md

This reference was placed toward the top of the document, before the Version History section.
Scrubs all CFE unit test functions to ensure that:

1. All functions in the CFE public API have a stub function implemented
2. All parameters to the stub function are registered in the context object,
   so the values will be available to hook functions.
3. The names of all parameters match the prototype/documentation, so hook
   functions that use name-based argument value retrieval will work.
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 26, 2020
@astrogeco
Copy link
Contributor

CCB 2020-07-01: APPROVED

@astrogeco astrogeco added CCB:FastTrack and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jul 1, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate July 2, 2020 19:24
@astrogeco astrogeco merged commit 4f9c331 into nasa:integration-candidate Jul 2, 2020
@skliper skliper added this to the 6.8.0 milestone Aug 21, 2020
@jphickey jphickey deleted the fix-762-ut-stub-scrub branch October 14, 2020 03:28
@skliper skliper linked an issue Mar 1, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrub all CFE UT stub functions ut_sb_stubs.c needs a stub for CFE_SB_ZeroCopyGetPtr
5 participants