Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CFE_SB_GetUserData unit test to catch padding differences between header/payload #903

Closed
skliper opened this issue Sep 23, 2020 · 0 comments · Fixed by #905 or #1109
Closed

Update CFE_SB_GetUserData unit test to catch padding differences between header/payload #903

skliper opened this issue Sep 23, 2020 · 0 comments · Fixed by #905 or #1109
Labels
bug unit-test
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 23, 2020

Is your feature request related to a problem? Please describe.
CFE_SB_GetUserData returns the location right after the header, which isn't always the start of the payload if padding gets inserted.

Describe the solution you'd like
Add generic packets with all width types, and ensure the correct location is returned.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper mentioned this issue Sep 23, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Sep 23, 2020
@skliper
Fix nasa#903, Add CFE_SB_GetUserData padding check
4eba3c0
@skliper skliper mentioned this issue Sep 23, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Jan 7, 2021
@skliper
Fix nasa#903, Add CFE_SB_GetUserData padding check
856c88a
@skliper skliper mentioned this issue Jan 7, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Jan 11, 2021
astrogeco added a commit that referenced this issue Jan 25, 2021
@astrogeco
Merge pull request #905 from skliper/fix903-getuserdata-padcheck
6ca043d 
Fix #903, Add CFE_SB_GetUserData padding check
@astrogeco astrogeco mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unit-test
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco