Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake build not correctly using the "${CPUNAME}_SYSTEM" directive #906

Closed
jphickey opened this issue Sep 23, 2020 · 0 comments · Fixed by #907 or #912
Closed

CMake build not correctly using the "${CPUNAME}_SYSTEM" directive #906

jphickey opened this issue Sep 23, 2020 · 0 comments · Fixed by #907 or #912
Assignees
@jphickey
Labels
bug
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Describe the bug
With the current main branch even if the ${CPUNAME}_SYSTEM variable is correctly set, it is being ignored. SIMULATION works fine though.

To Reproduce
Run make prep without SIMULATION and a targets.cmake file with cpu1_SYSTEM set to something non-empty.
Unexpected error is generated:

CMake Error at cmake/mission_build.cmake:332 (message):
  Unable to find toolchain file for default

Expected behavior
Should generate build tree and build successfully.

System observed on:
GSFC MCP750 test build

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey added the bug label Sep 23, 2020
@jphickey jphickey self-assigned this Sep 23, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Sep 23, 2020
@jphickey
Fix nasa#906, Update variable checks in read_targetconfig
8a8ac31 
This was using "DEFINED" to check if these variables were set.
Problem discovered is that this is always true because "SIMULATION"
is a cache var set from an environment variable, so it ALWAYS defined,
it is just empty if not being used.

Fix is to use if (SIMULATION) rather than if (DEFINED SIMULATION) which
should only be true if the string is not empty, as intended.
@jphickey jphickey mentioned this issue Sep 23, 2020
Merged
yammajamma added a commit that referenced this issue Sep 24, 2020
@yammajamma
Merge pull request #907 from jphickey/fix-906-cmake-system
ce187a2 
Fix #906, Update variable checks in read_targetconfig
@yammajamma yammajamma mentioned this issue Sep 24, 2020
Merged
@astrogeco astrogeco added this to the 7.0.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @astrogeco