Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move typedefs used in cmd/tlm to the *_msg.h file #909

Closed
skliper opened this issue Sep 23, 2020 · 1 comment · Fixed by #964 or #991
Closed

Move typedefs used in cmd/tlm to the *_msg.h file #909

skliper opened this issue Sep 23, 2020 · 1 comment · Fixed by #964 or #991
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 23, 2020

Is your feature request related to a problem? Please describe.
CFE_ES_AppInfo_t and CFE_ES_MemHandle_t are defined in cfe_es.h, but used in telemetry (cfe_es_msg.h). All the typedefs used in telemetry should be defined in the *_msg.h file.

Describe the solution you'd like
Move CFE_ES_AppInfo_t and CFE_ES_MemHandle_t into cfe_es_msg.h

Note CFE_ES_TaskInfo_t is not used in cmd/tlm.

Describe alternatives you've considered
None

Additional context
Related to #899

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper changed the title Move structures used in tlm to the *_msg.h file Move typedefs used in cmd/tlm to the *_msg.h file Sep 23, 2020
@jphickey
Copy link
Contributor

I'd like to move this definition after review/merge of #917, as this changes CFE_ES_MemHandle_t.

Once decided (along with #913) then I suggest that the handle/resourceid types go into cfe_es_extern_typedefs.h and the structures go into cfe_es_msg.h.

jphickey added a commit to jphickey/cFE that referenced this issue Oct 26, 2020
@jphickey
Fix nasa#909, reorganize ES public API + msg definitions
9da1c8a 
Put all ES typedefs which are shared across API and telemetry
messages into the "cfe_es_extern_typedefs.h" file.

Put all ES typedefs which define the telemetry interface
into the "cfe_es_msg.h" file.  Also include structures which
define the output of commands that write data files into this
group (query all apps, query all tasks, query all CDS).

Removes some localized definitions and replace with MISSION
scope definitions where appropriate/necessary.
jphickey added a commit to jphickey/cFE that referenced this issue Oct 26, 2020
@jphickey
Fix nasa#909, reorganize ES public API + msg definitions
e6296e6 
Put all ES typedefs which are shared across API and telemetry
messages into the "cfe_es_extern_typedefs.h" file.

Put all ES typedefs which define the telemetry interface
into the "cfe_es_msg.h" file.  Also include structures which
define the output of commands that write data files into this
group (query all apps, query all tasks, query all CDS).

Removes some localized definitions and replace with MISSION
scope definitions where appropriate/necessary.
This was referenced Oct 26, 2020
Merged
Closed
@astrogeco astrogeco added this to the 7.0.0 milestone Oct 27, 2020
@jphickey jphickey mentioned this issue Oct 27, 2020
Closed
@jphickey jphickey added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Oct 27, 2020
@jphickey jphickey mentioned this issue Oct 27, 2020
Closed
astrogeco added a commit that referenced this issue Oct 30, 2020
@astrogeco
Merge pull request #964 from jphickey/fix-909-extern-defs
398471a 
Fix #909, reorganize ES public API + msg definitions
@astrogeco astrogeco mentioned this issue Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco