Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix# 1009, Apply consistent alignment pattern #1015

Merged
merged 7 commits into from
Dec 8, 2020
Merged

Fix# 1009, Apply consistent alignment pattern #1015

merged 7 commits into from
Dec 8, 2020
+2,445 −2,357

Commits on Dec 8, 2020

  1. Fix nasa#1009, Alignment pattern - documentation 

    - Documentation updates for applying the alignment pattern
- Added Cmd to all command types
- Updated example code
- Converted Syslog to SysLog for consistency
- CFE_SB_RcvMsg now CFE_SB_ReceiveBuffer
- Replaced references to deprecated CFE_SB API's with MSG API's
    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    9eea99a View commit details
    Browse the repository at this point in the history

  2. Fix nasa#1009, Alignment pattern - Msg module updates 

    - CFE_MSG_Message_t no longer worst case alignment
- CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t now
  contain the base message type, CFE_MSG_Message_t
- Fixed size type issue in CFE_MSG_ComputeChecksum
- Replaced CFE_SB_TlmHdr_t and CFE_SB_CmdHdr_t with
  CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t
    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    7a30cbe View commit details
    Browse the repository at this point in the history

  3. Fix nasa#1009, Alignment pattern - stub updates 

    - Using CFE_SB_Buffer_t where appropriate
- Replaced CFE_SB_CMD_HDR_SIZE and CFE_SB_TLM_HDR_SIZE
  with sizeof the appropriate type
- Deprecated CFE_SB_SendMsg, CFE_SB_RcvMsg stubs
- Added CFE_SB_TransmitBuffer, CFE_SB_TransmitMsg, and
  CFE_SB_ReceiveBuffer stubs
    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    2af3371 View commit details
    Browse the repository at this point in the history

  4. Fix nasa#1009, Alignment pattern - unit tests 

    - Replaced CFE_SB_SendMsg and CFE_SB_PassMsg with CFE_SB_TransmitMsg
- Replaced CFE_SB_ZeroCopySend and CFE_SB_ZeroCopyPass with
  CFE_SB_TransmitBuffer
- Replaced CFE_SB_RcvMsg with CFE_SB_ReceiveBuffer
- Used CFE_SB_Buffer_t and CFE_MSG_Message_t where appropriate
- Added Cmd to all command types
- Changed Syslog to SysLog for consistency
- Removed "see also" blocks in documentation, APIs are already grouped
  and these typically don't add anything useful (simplifies maintenance)
    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    95c25e5 View commit details
    Browse the repository at this point in the history

  5. Fix nasa#1009, Alignment pattern - core updates 

    - Added CFE_SB_TransmitMsg, CFE_SB_TransmitBuffer,
  CFE_SB_ReceiveBuffer (partial nasa#1019 fix)
- Replace CFE_SB_RcvMsg with CFE_SB_ReceiveBuffer
- Deprecated CFE_SB_SendMsg, CFE_SB_PassMsg, CFE_SB_RcvMsg
  CFE_SB_ZeroCopyPass, CFE_SB_ZeroCopySend
- Use CFE_SB_Buffer_t for receiving and casting to command types
- Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in
  command and telemetry type definitions
- Use CFE_SB_TransmitMsg to copy the command and telemetry
  into a CFE_SB_Buffer_t and send it where needed
- Avoids need to create send buffers within the app (or union
  the packet types with CFE_SB_Buffer_t)
- Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t
  that formerly enforced alignment since these had potential
  to change the actual packet sizes
- No need to cast to CFE_MSG_Message_t anywhere since it's
  available in the CFE_SB_Buffer_t union
- CFE_MSG_Size_t redefined as size_t to simplify future
  transition
- Replaced Syslog with SysLog for consistency
- Added Cmd to all command typedefs
- Replaced CFE_SB_CMD_HDR_SIZE and CFE_SB_TLM_HDR_SIZE
  with sizeof the appropriate type
    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    d127a16 View commit details
    Browse the repository at this point in the history

  6. Fix nasa#1009, Doc update from PR review

    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    f4794fd View commit details
    Browse the repository at this point in the history

  7. Fix nasa#1009, Remove extra UT_SetForceFail from merge

    @skliper
    skliper committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    7c1bd8f View commit details
    Browse the repository at this point in the history