Fix #1004, default stack size #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not enforce CFE_PLATFORM_ES_DEFAULT_STACK_SIZE as a minimum, it should be a default.
jphickey
added
the
CCB:Ready
|
CCB 2020-11-18 APPROVED |
astrogeco
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Do not enforce
CFE_PLATFORM_ES_DEFAULT_STACK_SIZEas a minimum, it should be a default.Fixes #1004
Testing performed
Build and sanity test CFE.
Run all unit tests.
Expected behavior changes
This affects the Start App command.
If stack size is specified as zero, then the default stack size value from platform config is used. Otherwise the value in the command will be passed through and used as-is.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11
Additional context
No specific value is enforced at the ES level. Many RTOS's will implement any stack size requested - so no need for ES to get in the way and put arbitrary restrictions. Furthermore the value is documented as a default, not a minimum.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.