Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cFS-Caelum Review, CFS-42: SB, MSG, and Globals #1375

Closed
wants to merge 3 commits into from
Closed

cFS-Caelum Review, CFS-42: SB, MSG, and Globals #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb7dbec
cFS-42: Add .gitignore for SB, MSG, and Globals
astrogeco Apr 19, 2021
f394953
CFS-42: Add SB and SBR Files
astrogeco Apr 19, 2021
354271f
CFS-42: Add CCSDS/MSG Files
astrogeco Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Ignore everything
*

# ...even if they are in subdirectories
!*/

# But not these files...
!/.gitignore
!/README.md



# Software Bus (SB)
!modules/core_api/fsw/inc/cfe_sb*

!modules/core_private/fsw/inc/cfe_sb*

!modules/sb/fsw/**
!modules/sb/CMakeLists.txt

!modules/sbr/fsw/src/cfe_sbr**
!modules/sbr/CMakeLists.txt

# CCSDS Message
!modules/core_api/fsw/inc/cfe_msg*

!modules/msg/fsw/**
!modules/msg/option_inc/**
!modules/msg/CMakeLists.txt
25 changes: 24 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,24 @@
# cFE
## cFS-Caelum Review: CFS-42

This branch is meant for the cFS-Caelum code review of Software Bus, CCSDS Message and Global Variables. The review designation is "CFS-42"


The corresponding, fully-working cFE instance matching the code in this branch can be found under the [cFE v7.0.0-rc1 tag](https://github.com/nasa/cFE/releases/tag/v7.0.0-rc1)

### How to add your review comments

Navigate to the ["files changed" tab](https://github.com/nasa/cFE/pull/1375/files) in the [nasa/cFE#1375](https://github.com/nasa/cFE/pull/1375) pull request.


<img width="820" alt="github-review-instructions-1of2" src="https://user-images.githubusercontent.com/59618057/113956688-dca76a00-97eb-11eb-99d4-9ec84b459dce.png">


You can add comments on any line of code by hovering on the line number and clicking on the plus "+" sign. Once you're finished with the comment click on the green "Start Review" button. To add more comments, just click on the relevant line number in any file, type your comment, and click on "Add review comment".


<img width="1229" alt="github-review-instructions-2of2" src="https://user-images.githubusercontent.com/59618057/113956482-8508fe80-97eb-11eb-8197-618d4e25fa51.png">

If you need to take a break, or if you're done, click the green "Finish Review" button on the top right corner of the
page, add any overall or summarizing comments and click on "Submit Review". You can always return and add new comments using the same process.

**Thank you!**
Loading