Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1421, Correctly format code block section terminator #1491

Merged
merged 1 commit into from
May 19, 2021

Conversation

jbohren-hbr
Copy link
Contributor

@jbohren-hbr jbohren-hbr commented May 10, 2021

Describe the contribution

  • A code block wasn't terminated terminate properly, causing the markdown to not render correctly on GitHub.

Fix #1421

Testing performed

  1. View on GitHub

Expected behavior changes

  • No impact to behavior

System(s) tested on

  • N/A

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Company CLA from Honeybee Robotics on file.

The code block didn't terminate properly, causing the markdown to not render correctly on GitHub.
@astrogeco astrogeco added community Community contribution, YAY! docs This change only affects documentation. labels May 11, 2021
@astrogeco astrogeco changed the title doc: Fixing code block section terminator Fix #1421, Correctly format code block section terminator May 11, 2021
@astrogeco
Copy link
Contributor

Hi @jbohren-hbr thank you for the contribution!

Could you reformat your commit message to reference #1421? Specifically, we like to use the format
Fix #123, short description

Thanks!

@astrogeco astrogeco self-assigned this May 12, 2021
@astrogeco astrogeco added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 12, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate May 19, 2021 02:14
@astrogeco astrogeco merged commit 5ff1daa into nasa:integration-candidate May 19, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
nasa/cFE#1491, Correctly format code block section terminator
nasa/cFE#1530, Fix #1550, typos in developer guide

nasa/osal#987, Show CodeQL Preview
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
nasa/cFE#1491, Correctly format code block section terminator
nasa/cFE#1530, Fix typos in developer guide

nasa/osal#987, Show CodeQL Preview
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
Combines:

nasa/cFE#1508, cFE v6.8.0-rc1+dev580
nasa/osal#1006, osal v5.1.0-rc1+dev452

Includes:

nasa/cFE#1482, Resolve sequence count auto-increment rollover bug
nasa/cFE#1491, Correctly format code block section terminator
nasa/cFE#1530, Fix typos in developer guide

nasa/osal#985, rename hooks to handlers
nasa/osal#1000, propagate status code in OS_rmdir
nasa/osal#1001, rework "unit-tests" to use macros
nasa/osal#1003, remove extra newlines in utassert logs
nasa/osal#990, Add test for object id inline functions
nasa/osal#998, fixed invalid inputs for OS_mkdir
nasa/osal#812, Improves config guide documentation
nasa/osal#987, Show CodeQL Preview
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
Combines:

nasa/cFE#1508, cFE v6.8.0-rc1+dev580
nasa/osal#1006, osal v5.1.0-rc1+dev452

Includes:

nasa/cFE#1482, Resolve sequence count auto-increment rollover bug
nasa/cFE#1491, Correctly format code block section terminator
nasa/cFE#1530, Fix typos in developer guide

nasa/osal#985, rename hooks to handlers
nasa/osal#1000, propagate status code in OS_rmdir
nasa/osal#1001, rework "unit-tests" to use macros
nasa/osal#1003, remove extra newlines in utassert logs
nasa/osal#990, Add test for object id inline functions
nasa/osal#998, fixed invalid inputs for OS_mkdir
nasa/osal#812, Improves config guide documentation
nasa/osal#987, Show CodeQL Preview

Co-Authored-By: Jake Hageman <skliper@users.noreply.github.com>
Co-Authored-By: Joseph Hickey <joseph.p.hickey@nasa.gov>
Co-Authored-By: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
Co-Authored-By: Alex Campbell <zanzaben@users.noreply.github.com>
Co-Authored-By: Tobias Nießen <tniessen@users.noreply.github.com>
Co-Authored-By: Jonathan Bohren <jbohren-hbr@users.noreply.github.com>
Co-Authored-By: Andrei Tumbar <Kronos3@users.noreply.github.com>
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB community Community contribution, YAY! docs This change only affects documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links broken in cFE Application Developers Guide from broken code highlighting
3 participants