Fix #1474, #1552, Resolve API prototype/implementation discrepancies

[skliper]

Describe the contribution
Fix #1474 - This checks prototypes against implementation and fixes any differences (return type, parameter names, etc). For the most part implementation was considered truth (fixed prototype) except for CFE_Status_t return type change. Also fixes some but not all use of CFE_Status_t in the implementations.

Fix #1552 - note completed ut-stub updates after CCB, added in since they are trival.

Follow on work needed - Internal use of CFE_Status_t (#921)

Testing performed
Built and ran unit tests, all passed. Built usersguide and confirmed no errors.

Expected behavior changes
None

System(s) tested on

• Hardware: Docker on laptop
• OS: Ubuntu 18.04
• Versions: Bundle main + these commits

Additional context
Builds on commit from @zachar1a submitted in #1531, now closed as duplicate to this PR

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
Zachary Gonzalez - Individual

[astrogeco]

CCB:2021-05-19 APPROVED

• Builds on community contribution
• Removes old UT_TimeHandler
• There's open issues for future work

[skliper]

Added in the ut-stub updates with 7e3effd

[jphickey]

Note, going forward we should consider the names in the header/documentation to be part of the API. That is, a name change in the header is treated similarly to an API change like adding or removing an argument. That's because unit test hooks may now be referencing parameters by the names in the header/documentation.

So if/when in the future there are discrepancies found between header and implementation, it would be less impact (compatibility-wise) to update the implementation to match the header, rather than the header to match the implementation.

[astrogeco]

@skliper I see that the commits are all partials. Does their combination result in a full fix for both #1474 and #1552?

[zachar1a]

@astrogeco I only changed the implementation to match the prototypes for #1474. No work was done on my part to complete #921, another issue was also mentioned to remove the extern from both prototype and implementation. I didn't know if that should be another ticket or go in with this, so I just left them there.

[skliper]

@astrogeco The full set of commits does fix those issues as described and linked in the PR.

[skliper]

@astrogeco Amended the commit message on the last one since it alone fixed #1552, the first two together fixed #1474.