Fix #1678 Add Functional Tests for cFE Message ID APIs #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
previously requested changes
Jul 30, 2021
ArielSAdamsNASA
force-pushed
the
fix-1678-functional-test-cfe-message-id
branch
6 times, most recently
from
2b72fcf
to
c73d8da
Compare
ArielSAdamsNASA
added
the
CCB:Ready
zanzaben
suggested changes
Aug 3, 2021
| * the msg to type relationship is also implementation defined, black box test just calls the routine | ||
| * to confirm things don't "break" with full range values and the implementation exists. | ||
| */ | ||
| CFE_MSG_GetTypeFromMsgId(msgid, &msgtype); |
There was a problem hiding this comment.
This shouldn't just be not checked at all. It could be checked that the returns equals either CFE_SUCCESS or CFE_MSG_BAD_ARGUMENT, or could use UtAssert_NOT_NULL.
| CFE_MSG_Message_t msg; | ||
| CFE_SB_MsgId_t msgid = CFE_SB_ValueToMsgId(1); | ||
|
|
||
| UtAssert_INT32_EQ(CFE_MSG_SetMsgId(&msg, msgid), CFE_SUCCESS); |
There was a problem hiding this comment.
You should use GetMsgId to check that the value you set it to is also correct.
ArielSAdamsNASA
force-pushed
the
fix-1678-functional-test-cfe-message-id
branch
5 times, most recently
from
dd8e730
to
abca091
Compare
ArielSAdamsNASA
force-pushed
the
fix-1678-functional-test-cfe-message-id
branch
from
abca091
to
73c1565
Compare
zanzaben
approved these changes
Aug 3, 2021
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 4, 2021
nasa/cFE#1742, Remove SB get last message sender info requirement nasa/cFE#1732, Fix #1725 Update UTs to use UtAssert_MIR nasa/cFE#1736, Add Functional Tests cFE Message ID nasa/cFE#1707, Add Time Conversion Functional Test
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 6, 2021
**Combines** nasa/cFE#1759, v6.8.0-rc1+dev810 nasa/osal#1126, v5.1.0-rc1+dev586 **Includes** *cFE* - nasa/cFE#1752, Add null pointer check to table GetAddresses and ReleaseAddresses - nasa/cFE#1742, Remove SB get last message sender info requirement - nasa/cFE#1732, Fix #1725 Update UTs to use UtAssert_MIR - nasa/cFE#1736, Add Functional Tests cFE Message ID - nasa/cFE#1707, Add Time Conversion Functional Test - nasa/cFE#1739, Add cast to MIR prints *osal* - nasa/osal#1122, Add UtAssert_MIR macro - nasa/osal#1125, add generic asserts from CFE coverage testing - nasa/osal#1121, add osapi-shell-stubs.c to OSAL stub library Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Paul <pavll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1678
Add functional tests for cFE Message Id APIs
CFE_MSG_GetMsgId - Gets the message id from a message.
CFE_MSG_SetMsgId - Sets the message id bits in a message.
CFE_MSG_GetTypeFromMsgId - Gets message type using message ID.
Testing performed
Tested in functional tests and format check workflows on fork.
Expected behavior changes
Tests functionality for cFE Message Id APIs
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal