-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1760, check resource ID idx is less than max #1804
Merged
astrogeco
merged 1 commit into
nasa:integration-candidate
from
nmullane:fix1760-check-maximum-resource-id-index
Aug 13, 2021
Merged
Fix #1760, check resource ID idx is less than max #1804
astrogeco
merged 1 commit into
nasa:integration-candidate
from
nmullane:fix1760-check-maximum-resource-id-index
Aug 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
added
the
CCB:Approved
Indicates code review and approval by community CCB
label
Aug 11, 2021
CCB:2021-08-11 APPROVED with CHANGES
|
skliper
requested changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding the request to change so it doesn't get lost.
- Also deletes the created gen counter in TestCounterIDToIndex to clean up
nmullane
force-pushed
the
fix1760-check-maximum-resource-id-index
branch
from
August 12, 2021 17:51
e2fcf9e
to
6214ff2
Compare
skliper
approved these changes
Aug 12, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 13, 2021
- Check resource ID idx is less than max
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 17, 2021
**Combines** nasa/cFE#1808, v6.8.0-rc1+dev873 **Includes** - nasa/cFE#1790, Port "CFE_UtAssert_SuccessCheck" and related macros from coverage test to functional test #1784, add CFE assert macros to functional test - nasa/cFE#1779, Adds invalid id syslog to for CFE_ES_DeleteApp and CFE_ES_ReloadApp and verifies required reporting - nasa/cFE#1785, Stop memory leak & add cds size test. - nasa/cFE#1765, Mark read only inputs as const - nasa/cFE#1804, Check resource ID idx is less than max - nasa/cFE#1778, Add ES Application Behavior Functional Tests - nasa/cFE#1801, Update CFE_ES_RunLoop documentation - nasa/cFE#1745, Add Message Api Functional Test - nasa/cFE#1798, update in/out status and nonnull/nonzero tags - nasa/cFE#1783, Add External Time Source Functional Tests - nasa/cFE#1800, Add Perf API functional tests Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com> Co-authored-by: Paul <pavll@users.noreply.github.com>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 17, 2021
**Combines** nasa/cFE#1808, v6.8.0-rc1+dev873 **Includes** - nasa/cFE#1790, Port "CFE_UtAssert_SuccessCheck" and related macros from coverage test to functional test #1784, add CFE assert macros to functional test - nasa/cFE#1779, Adds invalid id syslog to for CFE_ES_DeleteApp and CFE_ES_ReloadApp and verifies required reporting - nasa/cFE#1785, Stop memory leak & add cds size test. - nasa/cFE#1765, Mark read only inputs as const - nasa/cFE#1804, Check resource ID idx is less than max - nasa/cFE#1778, Add ES Application Behavior Functional Tests - nasa/cFE#1801, Update CFE_ES_RunLoop documentation - nasa/cFE#1745, Add Message Api Functional Test - nasa/cFE#1798, update in/out status and nonnull/nonzero tags - nasa/cFE#1783, Add External Time Source Functional Tests - nasa/cFE#1800, Add Perf API functional tests Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Niall Mullane <nmullane@users.noreply.github.com> Co-authored-by: Paul <pavll@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1760
Testing performed
Steps taken to test the contribution:
Expected behavior changes
No impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern