Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1879, Improve EVS code coverage #1881

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 25, 2021

Describe the contribution
Fix #1879, now getting 100% line and branch coverage on EVS

Testing performed
Build unit tests, run, report coverage, confirm 100% on EVS

Expected behavior changes
None

System(s) tested on

  • Hardware: Intel i5/Docker
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 25, 2021
@skliper skliper added this to the 7.0.0 milestone Aug 25, 2021
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just noticed a typo in comment, that's all

modules/evs/ut-coverage/evs_UT.c Outdated Show resolved Hide resolved
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 25, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Aug 25, 2021

CCB:2021-08-25 APPROVED with small change

  • fix typo

@skliper
Copy link
Contributor Author

skliper commented Aug 26, 2021

Typo is fixed and slightly better loop limit on setting all apps used (eliminates dependency on actual type/name)

@astrogeco astrogeco changed the base branch from main to integration-candidate August 27, 2021 15:20
@astrogeco astrogeco merged commit af64eb4 into nasa:integration-candidate Aug 27, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 27, 2021
nasa/cFE#1876, SB test improvements

nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag

nasa/cFE#1881, Improve EVS code coverage
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 27, 2021
nasa/cFE#1876, SB test improvements

nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag

nasa/cFE#1881, Improve EVS code coverage
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 1, 2021
**Combines**

nasa/cFE#1885,              v6.8.0-rc1+dev980
nasa/osal#1138,             v5.1.0-rc1+dev598
nasa/cFS-GroundSystem#195,  v2.2.0-rc1+dev63

**Includes**

*cFE*

nasa/cFE#1870, Add SB API test cases
nasa/cFE#1869, Add ES API test cases
nasa/cFE#1872, Add TBL API test cases
nasa/cFE#1871, Add FS API test cases
nasa/cFE#1860, Add Time Clock Test
nasa/cFE#1862, EVS coverage test
nasa/cFE#1876, SB test improvements
nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag
nasa/cFE#1881, Improve EVS code coverage
nasa/cFE#1877, add call to CFE_ES_ExitChildTask
nasa/cFE#1902, Incorrect OSAL Format in Users Guide Reference
nasa/cFE#1884, Improve FS coverage
nasa/cFE, Improve MSG branch coverage
nasa/cFE#1891, Improve resource ID branch coverage
nasa/cFE#1894, Improve SBR branch coverage
nasa/cFE#1896, Fix #1895, Improve TIME branch coverage
nasa/cFE#1904, Improve TBL code coverage
nasa/cFE#1864, Support custom PSP directory
nasa/cFE#1913, Update time tests to use bitmask check macros
nasa/cFE#1923, remove extra word in comment

*osal*

nasa/osal#1136, add bitmask assert macros

*cFS-GroundSystem*

nasa/cFS-GroundSystem#190, Fix #189, Virtualenv and Pipenv .gitignore support
nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos

Co-authored-by: Jacob Hageman           <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey           <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell           <zanzaben@users.noreply.github.com>
Co-authored-by: Ariel Adams             <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Co-authored-by: Avi                     <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul                    <pavll@users.noreply.github.com>
@skliper skliper deleted the fix1879-evs_coverage branch October 22, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVS code coverage improvements
3 participants