Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2039, Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID #2042

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

paulober
Copy link
Contributor

Describe the contribution

Expected behavior changes

  • No impact to behavior

Contributor Info - All information REQUIRED for consideration of pull request
Paul Oberosler - Personal

@skliper skliper requested a review from zanzaben January 31, 2022 14:17
@skliper skliper added this to the Draco milestone Jan 31, 2022
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 31, 2022
@astrogeco astrogeco added community Community contribution, YAY! and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 2, 2022
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 2, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 2, 2022
@astrogeco
Copy link
Contributor

CCB:2022-02-01 APPROVED

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2022
*cFE v7.0.0-rc4+dev70*

nasa/cFE#2041, Improve CFE_SB_IsValidMsgId handler
nasa/cFE#2034, Update CodeQL workflow
nasa/cFE#2042, Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID

*osal v6.0.0-rc4+dev32*

nasa/osal#1209, typesafe definition of osal_id_t

*sample_app v1.3.0-rc4+dev9*

nasa/sample_app#165, Use preferred UT patterns

Co-authored-by: Jacob Hageman   <skliper@users.noreply.github.com>
Co-authored-by: Paul            <paulober@users.noreply.github.com>
Co-authored-by: Ariel Adams     <ArielSAdamsNASA@users.noreply.github.com>
@astrogeco astrogeco merged commit b3cdc34 into nasa:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB community Community contribution, YAY! draco-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID
3 participants