Fix #1460, Duplicated Logic in CFE_SB_BroadcastBufferToRoute #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
Sep 26, 2022
chillfig
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 3, 2022
*Combines:* cfe v7.0.0-rc4+dev183 psp v1.6.0-rc4+dev55 osal v6.0.0-rc4+dev116 sample_app v1.3.0-rc4+dev27 sch_lab v2.5.0-rc4:dev35 tblCRCTool v1.3.0-rc4+dev18 ci_lab v2.5.0-rc4+dev30 sample_lib v1.3.0-rc4+dev20 cFS-GroundSystem v3.0.0-rc4+dev25 **Includes:** *cFS* - #580, Addresses invalid CodeQL language option *cFE* - nasa/cFE#2145, Fixes issue #2144- Propagate CMAKE_EXPORT_COMPILE_COMMANDS variable - nasa/cFE#2148, Remove CodeQL Paths Ignore - nasa/cFE#2151, Duplicated Logic in CFE_SB_BroadcastBufferToRoute - nasa/cFE#2156, Remove 'return;' from last line of void functions. - nasa/cFE#2154, Remove unnecessary parentheses around return values. *osal* - nasa/osal#1181, Use fstat and fchmod for TOCTOU Bug - nasa/osal#1294, Remove 'return;' from last line of void functions. - nasa/osal#1292, Remove unnecessary parentheses around return values. *sample_app* - nasa/sample_app#177, Misaligned comments - nasa/sample_app#179, Remove unnecessary parentheses around return values. - nasa/sample_app#181, Remove 'return;' from last line of void functions. *sch_lab* - nasa/sch_lab#120, Remove unnecessary parentheses around return values. *tblCRCTool* - nasa/tblCRCTool#69, Remove unnecessary parentheses around return values. *ci_lab* - nasa/ci_lab#116, Remove unnecessary parentheses around return values. - nasa/ci_lab#118, Remove 'return;' from last line of void functions. *sample_lib* - nasa/sample_lib#84, Remove unnecessary parentheses around return values. *cFS-GroundSystem* - nasa/cFS-GroundSystem#222, Remove 'return;' from last line of void functions. Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored-by: Andrew Liounis <aliounis@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 3, 2022
*Combines:* cfe v7.0.0-rc4+dev183 psp v1.6.0-rc4+dev55 osal v6.0.0-rc4+dev116 sample_app v1.3.0-rc4+dev27 sch_lab v2.5.0-rc4:dev35 tblCRCTool v1.3.0-rc4+dev18 ci_lab v2.5.0-rc4+dev30 sample_lib v1.3.0-rc4+dev20 cFS-GroundSystem v3.0.0-rc4+dev25 **Includes:** *cFS* - #580, Addresses invalid CodeQL language option *cFE* - nasa/cFE#2145, Fixes issue #2144- Propagate CMAKE_EXPORT_COMPILE_COMMANDS variable - nasa/cFE#2148, Remove CodeQL Paths Ignore - nasa/cFE#2151, Duplicated Logic in CFE_SB_BroadcastBufferToRoute - nasa/cFE#2156, Remove 'return;' from last line of void functions. - nasa/cFE#2154, Remove unnecessary parentheses around return values. *osal* - nasa/osal#1181, Use fstat and fchmod for TOCTOU Bug - nasa/osal#1294, Remove 'return;' from last line of void functions. - nasa/osal#1292, Remove unnecessary parentheses around return values. *sample_app* - nasa/sample_app#177, Misaligned comments - nasa/sample_app#179, Remove unnecessary parentheses around return values. - nasa/sample_app#181, Remove 'return;' from last line of void functions. *sch_lab* - nasa/sch_lab#120, Remove unnecessary parentheses around return values. *tblCRCTool* - nasa/tblCRCTool#69, Remove unnecessary parentheses around return values. *ci_lab* - nasa/ci_lab#116, Remove unnecessary parentheses around return values. - nasa/ci_lab#118, Remove 'return;' from last line of void functions. *sample_lib* - nasa/sample_lib#84, Remove unnecessary parentheses around return values. *cFS-GroundSystem* - nasa/cFS-GroundSystem#222, Remove 'return;' from last line of void functions. Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored-by: Andrew Liounis <aliounis@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #1460
Removes duplicated logic in the final if/else in CFE_SB_BroadcastBufferToRoute.
Testing performed
Standard cFS bundle tests performed.
Expected behavior changes
No impact on behavior.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
cFE v7.0.0-rc4+dev171
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt