Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2559, Improve CFE_SB_AllocateMessageBuffer error report #2560

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

skliper
Copy link
Contributor

@skliper skliper commented May 10, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI and ran in project context

Expected behavior changes
Improved error message

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 10, 2024
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 16, 2024
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, fairly low impact/risk, and the nominal case is basically unchanged.
Does raise a flag to me that we might need something like CFE_ES_WriteToSyslogWithAppID() or something like that, but we can save that for another day.

@skliper
Copy link
Contributor Author

skliper commented May 23, 2024

Seems good to me, fairly low impact/risk, and the nominal case is basically unchanged. Does raise a flag to me that we might need something like CFE_ES_WriteToSyslogWithAppID() or something like that, but we can save that for another day.

Love the idea, and function maybe via a macro? Standardization is awesome.

@jphickey
Copy link
Contributor

Love the idea, and function maybe via a macro? Standardization is awesome.

Mainly because I was back into some TBL services code and this pattern appears a few times - to get the app name for the purpose of writing to syslog with an app context....

dzbaker added a commit to nasa/cFS that referenced this pull request Jul 2, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
elf2cfetbl equuleus-rc1+dev56

**Includes:**

*cFS*
- #707
- #773

*cFE*
- nasa/cFE#2560
- nasa/cFE#2344
- nasa/cFE#2359
- nasa/cFE#2376
- nasa/cFE#2496
- nasa/cFE#2554
- nasa/cFE#2568
- nasa/cFE#2566

*osal*
- nasa/osal#1456
- nasa/osal#1465

*elf2cfetbl*
- nasa/elf2cfetbl#147
- nasa/elf2cfetbl#124
- nasa/elf2cfetbl#125
- nasa/elf2cfetbl#127

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Jul 2, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 2, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
elf2cfetbl equuleus-rc1+dev56

**Includes:**

*cFS*
- #707
- #773

*cFE*
- nasa/cFE#2560
- nasa/cFE#2344
- nasa/cFE#2359
- nasa/cFE#2376
- nasa/cFE#2496
- nasa/cFE#2554
- nasa/cFE#2568
- nasa/cFE#2566

*osal*
- nasa/osal#1456
- nasa/osal#1465

*elf2cfetbl*
- nasa/elf2cfetbl#147
- nasa/elf2cfetbl#124
- nasa/elf2cfetbl#125
- nasa/elf2cfetbl#127

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@dzbaker dzbaker merged commit ab69280 into nasa:main Jul 2, 2024
22 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 2, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
elf2cfetbl equuleus-rc1+dev56

**Includes:**

*cFS*
- #707
- #773

*cFE*
- nasa/cFE#2560
- nasa/cFE#2344
- nasa/cFE#2359
- nasa/cFE#2376
- nasa/cFE#2496
- nasa/cFE#2554
- nasa/cFE#2568
- nasa/cFE#2566

*osal*
- nasa/osal#1456
- nasa/osal#1465

*elf2cfetbl*
- nasa/elf2cfetbl#147
- nasa/elf2cfetbl#124
- nasa/elf2cfetbl#125
- nasa/elf2cfetbl#127

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 15, 2024
*Combines:*

cFE equuleus-rc1+dev167
osal equuleus-rc1+dev81

**Includes:**

*cFE*
- nasa/cFE#2560

*osal*
- nasa/osal#1456
- nasa/osal#1465

Co-authored by: Anh Van <avan989@users.noreply.github.com>
Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Jul 15, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 15, 2024
*Combines:*

cFE equuleus-rc1+dev167
osal equuleus-rc1+dev81

**Includes:**

*cFE*
- nasa/cFE#2560

*osal*
- nasa/osal#1456
- nasa/osal#1465

Co-authored by: Anh Van <avan989@users.noreply.github.com>
Co-authored by: Dan Knutsen <dmknutsen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CFE_SB_AllocateMessageBuffer error reporting
3 participants