Set OSAL_SYSTEM_BSPTYPE for native builds #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly specifies the BSP to use when using SIMULATION=native flags to the build. All other example toolchain files already included this setting.
skliper
approved these changes
Dec 22, 2019
skliper
added
the
CCB:Approved
|
CCB 20190108 - Reviewed and approved for integration candidate |
skliper
added a commit
that referenced
this pull request
Jan 14, 2020
Fix #438: Set OSAL_SYSTEM_BSPTYPE for native builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #438
This explicitly specifies the BSP to use when using
SIMULATION=nativeflags to the build. All other example toolchain files already included this setting.Testing performed
Rebuild code with and without
SIMULATION=nativeflag. Confirmed no build issues/changes.Expected behavior changes
No impact - build script change only.
System(s) tested on:
Ubuntu 18.04 LTS 64-bit
Additional context
This makes it compatible after a related OSAL build script cleanup is also merged (see nasa/osal#312, nasa/osal#261).
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted