Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #617, Updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator #575

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix #617, Updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator #575

merged 1 commit into from
Apr 21, 2020

Conversation

dmknutsen
Copy link
Contributor

@dmknutsen dmknutsen commented Mar 30, 2020 •
edited by skliper
Loading

Describe the contribution
Fixes #617

Related to nasa/osal#88, updates documentation to note that the actual length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME include the null terminator.

Testing performed
Ran unit tests.

System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.11.0, OSAL 5.0.9.0, PSP 1.4.7.0

Contributor Info
Dan Knutsen
NASA/Goddard

@dmknutsen dmknutsen changed the title Fixes 88, makes requested documentation updates Fixes #88, makes requested documentation updates Mar 30, 2020
@dmknutsen
Fixes nasa#88, updates comments to note that the length limit of OS_M…
f5e4c50 
…AX_PATH_LEN and OS_MAX_API_NAME includes null terminator
@dmknutsen dmknutsen changed the title Fixes #88, makes requested documentation updates Fixes #88, updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Mar 30, 2020
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 9, 2020
@astrogeco astrogeco changed the title Fixes #88, updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Fix #88, updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Apr 14, 2020
@astrogeco astrogeco changed the title Fix #88, updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Fix #88, Updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Apr 14, 2020
@astrogeco
Copy link
Contributor

CCB 20200415 - APPROVED

@skliper skliper changed the title Fix #88, Updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Fix #617, Updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator Apr 15, 2020
@astrogeco
Copy link
Contributor

related to nasa/osal#88

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB - 20200415 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 21, 2020 22:17
@astrogeco astrogeco merged commit bd6707c into nasa:integration-candidate Apr 21, 2020
@astrogeco astrogeco added the docs This change only affects documentation. label Apr 27, 2020
@astrogeco astrogeco mentioned this pull request Apr 27, 2020
Merged
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation.
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Document length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator
3 participants
@dmknutsen @astrogeco @skliper