Integration Candidate: 2020-08-19 #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements message header module such that users can customize or extend as needed. - Separates code for easier selection - Implements consistent getter/setter APIs - Fix #736/#781: MsgId logic no longer overrides bits in init - Fix #529: Get size supports max size - Adds single big endian time implementation, but not selected - Adds msg module to module list - Adds msg module to cppcheck
- Removes dependencies on old macros - Simplifies unit tests - Treats msg module as internal code for now (temporary)
Fix #711, Separate secondary header access functions
Fix #795, Remove legacy time header format support
Fix #794, Add msg stubs and update SB UT
|
@skliper check out error in Travis https://travis-ci.com/github/nasa/cFS/jobs/377032649 |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 25, 2020
Contains: nasa/cFE#833 nasa/osal#576 nasa/to_lab#58 nasa/sch_lab#52 1. Update submodules for IC-20200819 2. Update cfe to reflect HOTFIX nasa/cFE#838 3. Point submodules to main for IC-20200819 Co-authored-by: Yasir Khan <yasir.majeed@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #794
Fix #795
Fix #92
Fix #711
Fix #733
Fix #736
Fix #597
Fix #529
Fix #781
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/130/checks
Expected behavior changes
PR #819 - Add msg stubs, update
SB_UTto use them, and remove msg module include from unit testsPR #801 - Collapses time options down to just 32 bit second, 16 bit subsecond, always big endian. Removes old defines, and triggers an error if the configuration is set to a format that was removed.
PR #726 - Enables source selection and out-of-tree mission-defined overrides in the msg directory
System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#130
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC