Fix #858, use osal id typedef #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the OSAL-supplied typedef `osal_id_t` to store OSAL IDs, along with OSAL-supplied conversion/cast routines when interfacing this value with other modules.
jphickey
added
CCB:Ready
|
CCB 2020-09-09 APPROVED, probably want to look at using Open/Create in a separate pull request. |
yammajamma
added
IC-20200909
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Scrub all CFE references/uses of OSAL IDs to use the proper
osal_id_ttype.Any place that an OSAL ID is stored in memory or passed in an API call are changed to the
osal_id_ttype, rather thanuint32. Conversions between this and other types (e.g. bare integer) is done using the OSAL-supplied conversion helpers.Fixes #858
Testing performed
Build and sanity check CFE
Run all unit tests
Also specifically spot check various CFE commands that save data to file (e.g. perf log, query all tasks, etc) to confirm these files are being properly created - as these previously used the
int32type to store the file handle and necessitated a bigger change.Expected behavior changes
No impact to behavior. Since the
osal_id_tis initially a typedef touint32, this should be effectively no change except to future proof.System(s) tested on
Ubuntu 20.04
Additional context
Depends on nasa/osal#568 which provides the typedef and conversion helpers (currently in IC)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.