Fix #893, replace calls to OS_open and OS_creat #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OS_OpenCreate instead, which has an API consistent with the rest of OSAL. OS_open and OS_create will be deprecated.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Sep 22, 2020
|
CCB 2020-09-23 APPROVED |
yammajamma
added
CCB-20200923
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Use
OS_OpenCreate(), which has an API consistent with the rest of OSAL.OS_openandOS_createwill be deprecated in nasa/osal#556.Fixes #893
Testing performed
Build CFE and run unit tests
Sanity test CFE by sending commands that use files (e.g.
CFE_ES_QUERY_ALL_TASKS_CC) using cmdUtil and verify functionality is not changed.Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 20.04
Additional context
Note that OS_open and OS_creat were already just backward compatibility wrappers around
OS_OpenCreatethat mimicked the historical API. This just bypasses the wrapper.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.