Integration Candidate: 2020-10-20 #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement consistent conversion/lookup functions to translate between names and IDs for all resource types. Also reorganize all internal resource ID functions into a separate source file for better organization. Clean up documentation and references.
Use the entire resource ID space (16 bits) and do not immediately recycle ID values until the full space is used. Implement a generic routine to find the next available ID, and modify every resource ID allocation to use this routine. Where necessary, this also corrects for differences in argument checking and duplicate checking between the various resource types. All resource allocation procedures now have consistent argument checking, and will reject duplicate name creation for any resources that are also associated with names.
There is no need to store the main task name a second time in the app record, as it is already stored in the task record.
Add a NULL check to CFE_ES_ResourceID_ToIndex_Internal(). Although this function is internal, it does check arguments on behalf of the public APIs which call this.
For backward compatibility - remove logic that actually made thes different numerical values. This should be put back in at some point.
Due to a merge the setting of this to its final value got moved. Need to use "Pending" value, not the one in the table record.
|
Fixed - this was some sort of merge/rebase issue, the line that sets the ID got moved but the refs before it were using the wrong (reserved) value not the correct (pending) value. |
astrogeco
force-pushed
the
integration-candidate
branch
from
5f8320a
to
7477e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #943
Fix #924
Fix #502
Testing performed
Bundle CI: https://github.com/nasa/cFS/pull/152/checks
Expected behavior changes
PR #946
System(s) tested on
Ubuntu
Additional context
Part of nasa/cFS#152
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey