Integration Candidate: 2020-06-17 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend updated accordingly. Other various tweaks/fixes as needed
Fix #98, Refactor individual UI elements to tables
|
This pull request fixes 3 alerts when merging c7f9072 into 52f706b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging ddee8c8 into 52f706b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 63b672a into 52f706b - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #98
Fix #104
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/106/checks
Expected behavior changes
PR #100 - Change all individual UI elements to table widgets. Update backend code accordingly
PR #106 - Temporary fix for implicit declaration of endian functions on some systems (RH/CentOs). Note the real fix will be #95, custom implementation of these functions and removal of the messy defines. No build errors on CentOS
System(s) tested on
Ubuntu: Bionic
Additional context
Part of nasa/cFS#106
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA-GSFC
Jacob Hageman, NASA-GSFC