Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CodeQL Paths Ignore Issues #575

Closed
3 tasks done
ArielSAdamsNASA opened this issue Sep 13, 2022 · 0 comments · Fixed by #577
Closed
3 tasks done

Resolve CodeQL Paths Ignore Issues #575

ArielSAdamsNASA opened this issue Sep 13, 2022 · 0 comments · Fixed by #577

Comments

@ArielSAdamsNASA
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The CodeQL workflow throws issues for using paths ignore in the codeql-analysis.yml file.

Describe the solution you'd like
Use zbazztian/filter-sarif@master in the codeql-reusable.yml file to avoid these issues. I tested this on fork and it does not throw issues.

Describe alternatives you've considered
Keep as is to allow each submodule to specify which files to ignore. If we want to keep the files to ignore consistent for each submodule/repo, then filter-sarif should be used to reduce redundancy.

Additional context
Files that are ignored in cFS and cFE:
- '/*.md'
- '
/.txt'
- '**/
.dox'

Submodules like osal, psp, and sc do not ignore any files.

Requester Info
Ariel Adams, MCSG Tech

@ArielSAdamsNASA ArielSAdamsNASA self-assigned this Sep 14, 2022
dzbaker added a commit that referenced this issue Sep 16, 2022
…ore-issues

Fix #575, Resolve CodeQL Paths Ignore Issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant