Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Analysis Failing on Second SARIF Upload #593

Closed
1 of 2 tasks
ArielSAdamsNASA opened this issue Oct 14, 2022 · 0 comments · Fixed by #594
Closed
1 of 2 tasks

Static Analysis Failing on Second SARIF Upload #593

ArielSAdamsNASA opened this issue Oct 14, 2022 · 0 comments · Fixed by #594

Comments

@ArielSAdamsNASA
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
The cppcheck or static analysis workflow fails when reaching the upload of the second sarif file. This is because if you try to upload multiple SARIF files for the same tool and category in a single GitHub Actions workflow run, the misconfiguration is detected and the run will fail.

Expected behavior
Upload two SARIF files in one commit.

Additional context
Documentation: https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning

To fix this issue, the workflow should use different ids, categories, or tool names.

Reporter Info
Ariel Adams, MCSG Tech

@ArielSAdamsNASA ArielSAdamsNASA self-assigned this Oct 14, 2022
dzbaker added a commit that referenced this issue Oct 25, 2022
…-second-upload

Fix #593, Add Category to Cppcheck Workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant