Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #185, Apply CodeQL to Every Branch #187

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix #185, Apply CodeQL to Every Branch #187

merged 1 commit into from
Feb 16, 2021

Conversation

ArielSAdamsNASA
Copy link
Contributor

@ArielSAdamsNASA ArielSAdamsNASA commented Feb 11, 2021

Describe the contribution
Fix #185 Removed main branch on push and pull-request. Added a timeout. Removed cFS running.

Expected behavior changes
CodeQL should run on every branch of cFS and timeout. cFS should not run, only build, since CodeQL does not require cFS to run for analysis.

System(s) tested on
CI

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA added CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. security CCB:FastTrack and removed CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. labels Feb 11, 2021
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if when pushing to a fork, setting the repository as nasa/cFS may actually do the analysis on the main branch in nasa/cFS?

@ArielSAdamsNASA
Copy link
Contributor Author

ArielSAdamsNASA commented Feb 12, 2021

I'm curious if when pushing to a fork, setting the repository as nasa/cFS may actually do the analysis on the main branch in nasa/cFS?

@skliper It seems that the analysis is done on the branch the user pushes the code to, whether or not nasa/cFS is used.

I tested this locally on my fork. I pushed a file and CodeQL ran automatically on push. I then went into the Actions tab and viewed the workflows for the new branch, TestPush, using the filters. Then, I changed the CodeQL workflow to remove the repository nasa/CFS code and pushed another file to that same branch. CodeQL also ran again automatically on the branch I pushed the code to which is TestPush.

image

@skliper
Copy link
Contributor

skliper commented Feb 12, 2021

@ArielSAdamsNASA after the checkout in the workflow, could you and a version check? Just add:

      - name: Check versions
        run: |
           git log -1 --pretty=oneline
           git submodule

after checkout and confirm the branch used in the build is your branch (when run from the fork)? You can also simplify from make install to just make, the install only moves the built files so doesn't affect the analysis.

@ArielSAdamsNASA
Copy link
Contributor Author

@skliper I added a version check and remove install from make install

I also pushed code again to the TestPush branch on my fork after making these changes. TestPush is the branch used in the build for the CodeQL workflow. The main branch is not found in the log. Here is the full raw log: TestPushLog.txt

image

image

@astrogeco astrogeco merged commit fd40b9e into nasa:main Feb 16, 2021
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Fix nasa#186, CF table name and default polling disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply CodeQL to Every Branch
4 participants