Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #554, Updated ubuntu version in CI workflows #559

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fix #554, update OS versions in github workflows

Testing performed
Check workflow results after pushing

Expected behavior changes
no impact to behavior

System(s) tested on
Browser

Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA

@ArielSAdamsNASA
Copy link
Contributor

Could also use "ubuntu-latest" so we don't have to update the workflows every time a new version comes out.

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I actually prefer explicit 22.04 for elements that are most likely to be impacted by updates so we have better control over when the update happens (vs a surprise when GitHub updates their ubuntu-latest). Is there a matching set of updates in the submodules for any changes needed to pass that should be marked as dependencies? I suspect there's at least minor format updates?

@havencarlson havencarlson added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Sep 1, 2022
@dzbaker dzbaker added CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 1, 2022
@havencarlson havencarlson force-pushed the workflow-ubuntu-update branch 3 times, most recently from 0f73291 to 95d9303 Compare September 6, 2022 16:07
@havencarlson havencarlson force-pushed the workflow-ubuntu-update branch 2 times, most recently from 42a5fde to 7d97ef0 Compare October 18, 2022 17:53
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note Ubuntu 20.04 default (if you just install clang-format) is version 10.0.0, which is the same as clang-format-10. If you go to 12, you'll need to update all the impacted repos to avoid CI failures from the switch. Seems like it's easier to just stick w/ 10 for Ubuntu 20.04?

@skliper
Copy link
Contributor

skliper commented Oct 18, 2022

I think the cppcheck workflow failed for at least osal with Ubuntu 20.04, but should probably check them all.

@havencarlson havencarlson added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. labels Oct 24, 2022
dzbaker added a commit that referenced this pull request Oct 26, 2022
*Combines:*

cfe v7.0.0-rc4+dev201
osal v6.0.0-rc4+dev147

**Includes:**

*cFS*
- #594
- #559

*cFE*
- nasa/cFE#2184

*osal*
- nasa/osal#1319

Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Oct 26, 2022
2 tasks
dzbaker added a commit that referenced this pull request Oct 26, 2022
*Combines:*

cfe v7.0.0-rc4+dev201
osal v6.0.0-rc4+dev147

**Includes:**

*cFS*
- #594
- #559

*cFE*
- nasa/cFE#2184

*osal*
- nasa/osal#1319

Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
@dzbaker dzbaker merged commit fdf8d7b into nasa:main Oct 26, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB CCB:FastTrack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OS versions in CI workflows
4 participants