-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI for deploy docs, warnings, and simplify #61
Update CI for deploy docs, warnings, and simplify #61
Conversation
Integration Candidate 2020-03-18
@astrogeco @jphickey could you review and merge this? All just CI/README changes, and once this is in I can update the README to reference the deployment documentation (adds the cFE and OSAL user's guide auto-generated pdfs). NOTE - I did only test it in my fork w/ special settings to make it work. There is a chance it may fail the CI check on merge to master by another user, but I'll work with whoever does it to solve it ASAP. Likely failure case could be the GITHUB_TOKEN, but documentation says collaborators should have access to mine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems OK. One minor comment/question noted in the docs build.
Removes the "optimization" for big endian, unlikely to be useful.
Fix nasa#61, remove dependence on ENDIAN macro for checksum
Describe the contribution
Fix #28, Deploy documentation
Fix #60, config warnings except for the new ones
introduced by using the latest deployment version
Fix #47, removes permissive mode hack and updates README.md
Adds enforce of no doxygen warnings for osal and users guide
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Old CI script warnings resolved (2 remain based on using development version)
Now enforces no doxygen warnings for user guides
Will deploy documentation to gh_pages branch on push to master
System(s) tested on
Additional context
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC