CCB: 2023.06.08

Items for Discussion

CDKnightNASA

cFE PR #2370 fix#2358, adds TIME module command to set CFE_TIME_Print() format

@dmknutsen

cFE PR #2369 Fix #2368, cFE Functional Test 23

@chillfig

FM PR #108 Fix #86, Removes extraneous boolean logic in concat command

@jphickey

cFE PR #2367 Fix #2362, Add source routing APIs to SB

@thnkslprpt

CF PR #337 Fix #336, Apply consistent Event ID names to common events

CF PR #339 Fix #338, Move 'EID' to the end of Event ID names

CF PR #388 Fix #387, Update minor out-of-family naming/consistency issues in CF

CS PR #53 Fix #52, Apply consistent Event ID names to common events

CS PR #83 Fix #82, Convert integers holding boolean truth values to bool

CS PR #85 Fix #84, Remove side-effects and superfluous initializations

DS PR #110 Fix #107, Convert command success events to INFORMATION type

DS PR #61 Fix #60, Apply consistent Event ID names to common events

EdsLib PR #57 Fix #56, Update out-of-sync function paramater names and correct typos

FM PR #105 Fix #104, Make padding explicit in FM_MonitorReportEntry_t & FM_ChildQueueEntry_t

FM PR #107 Fix #106, Consolidate HK variables that are duplicated in the global struct

FM PR #60 Fix #59, Apply consistent Event ID names to common events

FM PR #96 Fix #95, Update command handler function message pointers and return

HK PR #27 Fix #26, Apply consistent Event ID names to common events

HS PR #51 Fix #50, Apply consistent Event ID names to common events

LC PR #46 Fix #45, Apply consistent Event ID names to common events

LC PR #48 Fix #16, Convert LC state macros to enums

MD PR #37 Fix #36, Apply consistent Event ID names to common events

MM PR #51 Fix #50, Apply consistent Event ID names to common events

SC PR #61 Fix #60, Apply consistent Event ID names to common events

SC PR #81 Fix #5, Use OS_stat instead of OS_OpenCreate to verify file existence

SC PR #95 Fix #18, Make compiler-added padding in SC_AtpControlBlock_t explicit

cFE PR #2272 Fix #1407, Add error report on EVS failure during log header write

cFE PR #2273 Fix #1466, Add status return to CFE_ES_WaitForStartupSync()

cFE PR #2274 Fix #1528, Move NO_SUCH_TABLE_ERR_EID into FindTableInRegistry and make optional

cFE PR #2276 Fix #1515, Remove unnecessary memset from CFE_TBL_LoadFromFile

cFE PR #2278 Fix #1708, Align padding explicitly in cfe_tbl_msg.h

cFE PR #2279 Fix #1723, Add NULL check for AppFileName parameter in CFE_ES_ReloadApp

cFE PR #2281 Fix #2280, Move calls to CFE_ES_GetAppName() higher to reduce code duplication

cFE PR #2283 Fix #2282, Move calls to CFE_SB_GetPipeName() up higher to reduce duplication

cFE PR #2285 Fix #1473, Add helper for CFE_SB_Write...InfoCmd() with common logic

cFE PR #2286 Fix #1467, Add syslog write for CFE_ES_WaitForSystemState() timeout

cFE PR #2294 Fix #1453, Remove sparsely used CFE_BIT-related macros

cFE PR #2302 Fix #1527, Implement common command-handler return pattern across cFE

cFE PR #2304 Fix #1684, Add functional tests for cFE SB Message ID APIs

cFE PR #2308 Fix #1398, Consistent use of CFE_EVS_EventType_Enum_t for EventType

cFE PR #2309 Fix #1448, Simplify and clarify EVS_AddLog logic

cFE PR #2318 Fix #2317, Correct unbalanced brackets in CFE_MSG_CMD_HDR_INIT macro

cFE PR #2324 Fix #2323, Remove unnecessary asserts in TIME invalid command length UT

cFE PR #2326 Fix #1432, Add element to write error event in CFE_EVS_WriteAppDataFileCmd()

cFE PR #2329 Fix #1929, Remove redundant status check in CFE_ES_RegisterCDSEx()

cFE PR #2330 Fix #1933, Remove unreachable/dead branch in CFE_ES_RunPerfLogDump()

cFE PR #2332 Fix #1519, Refactor CFE_TBL_SearchCmdHndlrTbl to simplify and unmix variables

cFE PR #2340 Fix #2339, Refactor common logic out of CFE_TIME_SetTime/MET/STCFCmd()

cFE PR #2342 Fix #2341, Rename TimeA/TimeB parameter to improve consistency

cFE PR #2344 Fix #2343, Update CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE macro in es_verify.h

cFE PR #2347 Fix #1143, SB_UT corrections and clear event count history after setup

cFE PR #2348 Fix #1397, Rename overloaded EVS_PacketID_t to EVS_EventContext_t

cFE PR #2351 Fix #1514, Use XOR to swap between ping-pong buffers (style change only)

cFE PR #2359 Fix #2116, Update comment re. limits of

cFS-GroundSystem PR #233 Fix #218, Update LogOverflowCounter Description

cFS-GroundSystem PR #235 Fix #234, Update incorrect variable descriptions in tlm.txt

cFS-GroundSystem PR #236 Fix #220, Add missing description fields to cfe-es-hk-tlm.txt

ci_lab PR #130 Fix #129, Apply consistent Event ID names to common events

ci_lab PR #131 Fix #52, Add version information to NOOP event

ci_lab PR #132 Fix #96, Check returns from CFE calls during init

ci_lab PR #139 Fix #138, Convert int32 return codes and variables to CFE_Status_t

ci_lab PR #141 Fix #140, Move function prototypes to header file

elf2cfetbl PR #122 Fix #91, Redo SymbolNames malloc to remove out-of-bounds write

elf2cfetbl PR #123 Fix #85, Add checks for all return values from fseek()

elf2cfetbl PR #124 Fix #86, Check return from chmod

elf2cfetbl PR #125 Fix #87, Check return value of stat()

elf2cfetbl PR #127 Fix #126, Move variables declared mid-function to the top

elf2cfetbl PR #134 Fix #133, Update references to CFE_FS_Header_t time members

osal PR #1331 Fix #1330, Move variables declared mid-function to the top

osal PR #1354 Fix #1353, Align mismatched function prototype/implem. parameter names

osal PR #1357 Fix #1356, Remove stray remaining 'goto' in OSAL test code

osal PR #1364 Fix #1109, Remove unimplemented test stub prototype

osal PR #1368 Fix #1107, Remove unreachable branch (superfluous if condition)

osal PR #1377 Fix #958, Convert some UT_GetStubCount to UtAssert_STUB_COUNT

osal PR #1378 Fix #1103, Implement OS_ERR_INVALID_PRIORITY return code check for RTEMS

osal PR #1379 Fix #1193, Change format of UtAssert_StringBufCompare

osal PR #1381 Fix #1380, Light coding standards cleanup

osal PR #1387 Fix #1386, Refactor initializations of POSIX return_code variables to simplify code

osal PR #1388 Fix #864, Refactor duplicate addrlen swtiches into an inline function

osal PR #1389 Fix #1101, Add functional test for NULL RemoteAddr in OS_SocketRecvFrom

osal PR #1390 Fix #1102, Correct return value bug in VxWorks OS_ShellOutputToFile_Impl

psp PR #380 Fix #379, Align mismatched function prototype/implem. parameter names

psp PR #381 Fix #274, Cleanup and add doxygen for cfe_psp.h

psp PR #383 Fix #382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro

psp PR #388 Fix #387, Replace hand-written function names with func

sample_app PR #189 Fix #188, Apply consistent Event ID names to common events

sample_app PR #195 Fix #194, Remove component-specific cFE header #includes

sample_app PR #198 Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns

sample_app PR #200 Fix #199, Add test for missing branch in SAMPLE_APP_Process()

sample_app PR #201 Fix #141, Zero out global data structure during initialization

sample_app PR #205 Fix #45, Move cmds and utils into separate files

sch_lab PR #134 Fix #133, Remove component-specific cFE header #includes

sch_lab PR #142 Fix #141, Convert int32 return codes and variables to CFE_Status_t

to_lab PR #134 Fix #133, Apply consistent Event ID names to common events

to_lab PR #146 Fix #145, Refactor mutually exclusive logic in if, else if block

to_lab PR #148 Fix #147, Add check for failure of CFE_EVS_Register() during initialization

to_lab PR #156 Fix #155, Convert int32 return codes and variables to CFE_Status_t

to_lab PR #158 Fix #157, Move function prototypes to header file