CI LAB "PDUMsgID" checking depends on SB macro

[skliper]

Originated by jphickey (22 on babelfish):

The CI LAB application attempts to verify that the PDUMsgId is within range by comparing it to the CFE_SB_HIGHEST_VALID_MSGID macro.
Unfortunately, this is a configuration macro that is specific to the SB implementation and may not be available in future builds. It makes assumptions about the way SB dispatches/handles messages that CI really should not be making.
This check also does not provide any real benefit - if the MsgID is out of range there is no major problem, it simply will not match any packets.
To improve compatibility with future SB improvements this extra check should be removed. Calling this a "defect" as it actually does break the build with the EDS branch.

[skliper]

Last status - CCB 5/8/2019 - Quick discussion

1. Reiterated option to just remove the check
2. Proposed removing the associated logic (was used to test CF 4 or so years ago)
3. Could use CFE_SB_IsValidMsgId() and simply send a warning event (notify user but still do what's been commanded)

Preference is 3.

[jphickey]

Pull request #33 removes this problematic feature, which should resolve this issue.

[skliper]

Resolved by #35 (removed offending code).