Multiple cleanup items for CI LAB #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has numerous quality issues and has repeatedly been a maintenance problem, and also is of questionable usefulness. It was agreed in the CCB to drop this feature.
This removes the need to use BSD socket calls directly within CI_LAB
jphickey
force-pushed
the
fix-23-27-34-ci-lab-cleanup
branch
from
5f873e0
to
655f025
Compare
|
Re-pushed branch to address some minor remaining cleanup items and also add a fix for #36 to the mix. Like the others, this needs to be sequential; all changes in this pull request depend on the one before it, and cannot be cherry-picked/rebased without conflicts. But they can be independently reviewed. |
Make the patterns in CI better match the patterns used in other modules (CFE core, Sample App, etc) - Separate each command into a separate handler function - Each command handler accepts a const pointer to the full message - Put Telemetry payload into a separate "Payload" sub-structure - Use naming conventions defined in conventions document Note the payload name changes only affect the FSW internal usage, the payload format for the ground system is not changed.
Add a global structure called "CI_LAB_Global" for all globals, getting them out of the global namespace. All other identifiers that remain in the global namespace should be prefixed consistently with CI_LAB_ to match the name of the app.
jphickey
force-pushed
the
fix-23-27-34-ci-lab-cleanup
branch
from
655f025
to
a9c51f1
Compare
|
Updated the changeset to put the event generator in the actual Reset command handler as opposed to the internal reset routine. This avoids a spurious reset event reported at startup. |
skliper
reviewed
Mar 2, 2020
skliper
approved these changes
Mar 2, 2020
|
See commit 07a7077, this updates the comment for |
Merged
This was referenced Aug 21, 2020
This was
linked to
issues
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Cleans up multiple aspects of the CI_LAB implementation. Details Below.
Fixes #23
Fixes #27
Fixes #34
These change sets are submitted as a single pull request, as they have inter-dependencies between them and will trigger conflicts if presented individually. This pull request still contains each fix as an individual commit, so each one can be independently reviewed.
For #27 / commit 157aac0: PDU introspection code in CI LAB has numerous quality issues and has repeatedly been a maintenance problem, and also is of questionable usefulness. It was agreed in the CCB to drop this feature.
For #23 / commit 3ff5cc1: Use the OSAL Socket API instead of calling BSD sockets functions directly. This is fairly straightforward.
For #34 / commit 5f873e0: Update the CI_LAB local command/telemetry processing logic to match the recommended patterns used in other modules. This applies the recommended naming conventions, message structure, and functional structure by giving each command a dedicated handler function.
Testing performed
Build for native for both debug/release builds, with unit tests enabled. Confirmed normal operation of CI_LAB for command ingest by running CFE and sending commands with cmdUtil.
Expected behavior changes
CFDP PDU manipulation with CI LAB is no longer supported. Normal command ingest behavior does not change.
System(s) tested on
Ubuntu 18.04 LTS 64 bit
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.