Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake script to use current best practices #135

Closed
jphickey opened this issue Apr 6, 2023 · 0 comments · Fixed by #136
Closed

Update cmake script to use current best practices #135

jphickey opened this issue Apr 6, 2023 · 0 comments · Fixed by #136

Comments

@jphickey
Copy link
Contributor

jphickey commented Apr 6, 2023

Is your feature request related to a problem? Please describe.
Build recipes should publish the module's include directories via the INTERFACE_INCLUDE_DIRECTORIES in property in cmake. This is what CFE modules do, but some of the framework apps are still using directory-scope include directories (old way).

Also, table names should match the app names they are associated with, unless there is a good reason not to.

Describe the solution you'd like
Change these to target-scope include directories (use target_include_directories, not include_directories)

Additional context
Notably this is important in order to be able to easily provide an alternative table content via the mission-provided files.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/ci_lab that referenced this issue Apr 6, 2023
Prefer target-scope properties over directory scope where applicable
jphickey added a commit to jphickey/ci_lab that referenced this issue Apr 6, 2023
Prefer target-scope properties over directory scope where applicable
@jphickey jphickey added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 6, 2023
dzbaker added a commit that referenced this issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant