You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Build recipes should publish the module's include directories via the INTERFACE_INCLUDE_DIRECTORIES in property in cmake. This is what CFE modules do, but some of the framework apps are still using directory-scope include directories (old way).
Also, table names should match the app names they are associated with, unless there is a good reason not to.
Describe the solution you'd like
Change these to target-scope include directories (use target_include_directories, not include_directories)
Additional context
Notably this is important in order to be able to easily provide an alternative table content via the mission-provided files.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
jphickey
added a commit
to jphickey/ci_lab
that referenced
this issue
Apr 6, 2023
Prefer target-scope properties over directory scope where applicable
jphickey
added
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
and removed
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Apr 6, 2023
Is your feature request related to a problem? Please describe.
Build recipes should publish the module's include directories via the
INTERFACE_INCLUDE_DIRECTORIES
in property in cmake. This is what CFE modules do, but some of the framework apps are still using directory-scope include directories (old way).Also, table names should match the app names they are associated with, unless there is a good reason not to.
Describe the solution you'd like
Change these to target-scope include directories (use
target_include_directories
, notinclude_directories
)Additional context
Notably this is important in order to be able to easily provide an alternative table content via the mission-provided files.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: