Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to build in Raspbian #32

Closed
CDKnightNASA opened this issue Jan 29, 2020 · 3 comments · Fixed by #35
Closed

fails to build in Raspbian #32

CDKnightNASA opened this issue Jan 29, 2020 · 3 comments · Fixed by #35
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CDKnightNASA
Copy link

Describe the bug
Building ci_lab under Raspbian (a Debian variant for Raspberry Pi SBC's) fails due to alignment issues.

/home/pi/cFS/apps/ci_lab/fsw/src/ci_lab_app.c:53:39: error: cast increases required alignment of target type [-Werror=cast-align]
 CFE_SB_Msg_t *     CI_IngestPointer = (CFE_SB_Msg_t *)&CI_IngestBuffer[0];
                                       ^
/home/pi/cFS/apps/ci_lab/fsw/src/ci_lab_app.c: In function ‘CI_ReportHousekeeping’:
/home/pi/cFS/apps/ci_lab/fsw/src/ci_lab_app.c:297:25: error: cast increases required alignment of target type [-Werror=cast-align]
     CFE_SB_TimeStampMsg((CFE_SB_Msg_t *)&CI_HkTelemetryPkt);
                         ^
/home/pi/cFS/apps/ci_lab/fsw/src/ci_lab_app.c:298:20: error: cast increases required alignment of target type [-Werror=cast-align]
     CFE_SB_SendMsg((CFE_SB_Msg_t *)&CI_HkTelemetryPkt);
                    ^
/home/pi/cFS/apps/ci_lab/fsw/src/ci_lab_app.c: In function ‘CI_ProcessPDU’:
/home/pi/cFS/apps/ci_lab/fsw/src/ci_lab_app.c:618:35: error: cast increases required alignment of target type [-Werror=cast-align]
                     checkSumPtr = (uint32 *)PduDataPtr;

To Reproduce
Build ci_lab on Raspbian.

Expected behavior
Should build without error.

System observed on:
Raspberry Pi Zero W

Additional context
Add any other context about the problem here.

Reporter Info
Christopher.D.Knight@nasa.gov

@CDKnightNASA CDKnightNASA self-assigned this Jan 29, 2020
@jphickey
Copy link
Contributor

I have fixes for these! These are the same general issue as in nasa/cFE#313. If you want you can assign this to me and just turn off -Wcast-align in your build for now.

@skliper
Copy link
Contributor

skliper commented Aug 21, 2020

@CDKnightNASA - could you confirm this has been fixed? Looks to me like it has.

@skliper skliper linked a pull request Aug 21, 2020 that will close this issue
@skliper
Copy link
Contributor

skliper commented Aug 21, 2020

Fixed by #35 (by inspection, if not reopen or open a new issue).

@skliper skliper closed this as completed Aug 21, 2020
@astrogeco astrogeco added the bug Something isn't working label Oct 1, 2020
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants