Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUMULUS-3833: Migrate ReconciliationReports data from DynamoDB to Postgres #3797

Merged
merged 14 commits into from
Oct 3, 2024
Merged

CUMULUS-3833: Migrate ReconciliationReports data from DynamoDB to Postgres #3797

merged 14 commits into from
Oct 3, 2024

Conversation

jennyhliu
Copy link
Contributor

@jennyhliu jennyhliu commented Sep 13, 2024 •
edited
Loading

Summary: Summary of changes

Addresses CUMULUS-3833: Data is migrated from DynamoDB ReconciliationReportsTable to RDS table

Changes

  • Added ReconciliationReportMigration lambda and instructions to migrate ReconciliationReports
    from DynamoDB to Postgres

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@jennyhliu jennyhliu changed the base branch from master to feature/es-phase-2 September 13, 2024 20:35
@jennyhliu jennyhliu marked this pull request as ready for review September 17, 2024 17:59
@jennyhliu jennyhliu marked this pull request as draft September 17, 2024 18:01
@jennyhliu jennyhliu marked this pull request as ready for review September 23, 2024 16:59
Nnaga1
Nnaga1 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Nnaga1 Nnaga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions I have after looking through it, the terraform/lambda code/tests look great as usual but I had some clarifying questions

CHANGELOG.md Show resolved Hide resolved
lambdas/reconciliation-report-migration/iam.tf Show resolved Hide resolved
lambdas/reconciliation-report-migration/main.tf Show resolved Hide resolved
lambdas/reconciliation-report-migration/package.json Show resolved Hide resolved
lambdas/reconciliation-report-migration/package.json Outdated Show resolved Hide resolved
lambdas/reconciliation-report-migration/tests/test-index.js Show resolved Hide resolved
lambdas/reconciliation-report-migration/variables.tf Show resolved Hide resolved
lambdas/reconciliation-report-migration/tests/test-reconciliation-reports.js Show resolved Hide resolved
lambdas/reconciliation-report-migration/tests/test-reconciliation-reports.js Show resolved Hide resolved
lambdas/reconciliation-report-migration/tests/test-reconciliation-reports.js Show resolved Hide resolved
Nnaga1
Nnaga1 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@Nnaga1 Nnaga1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering my questions, the work looks great! 🚀 🎈 🎊

@Nnaga1 Nnaga1 removed the in review label Oct 2, 2024
@jennyhliu jennyhliu merged commit 80c8e57 into feature/es-phase-2 Oct 3, 2024
3 checks passed
@jennyhliu jennyhliu deleted the jl/CUMULUS-3833 branch October 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nnaga1 Nnaga1 Nnaga1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyhliu @Nnaga1