Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SrcFilename and DstFilename not ensured to be null-terminated #45

Closed
CDKnightNASA opened this issue Jun 5, 2020 · 0 comments · Fixed by #46 or #47
Closed

SrcFilename and DstFilename not ensured to be null-terminated #45

CDKnightNASA opened this issue Jun 5, 2020 · 0 comments · Fixed by #46 or #47
Assignees
@CDKnightNASA
Labels
bug Something isn't working
Milestone
Bootes

Comments

@CDKnightNASA
Copy link
Contributor

Describe the bug
elf2cfetbl uses strncpy to load the SrcFilename and DstFilename strings, but does not ensure that the strings are null-terminated.

Additional context
This is related to nasa/cFE#730

Reporter Info
Christopher.D.Knight@nasa.gov
@CDKnightNASA CDKnightNASA self-assigned this Jun 5, 2020
CDKnightNASA added a commit to CDKnightNASA/elf2cfetbl that referenced this issue Jun 5, 2020
@CDKnightNASA
fix nasa#45 - null terminates src/dst filenames
f7636c9
@CDKnightNASA CDKnightNASA linked a pull request Jun 5, 2020 that will close this issue
Fix #45 - null terminates src/dst filenames #46
Merged
astrogeco added a commit that referenced this issue Jul 1, 2020
@astrogeco
Merge pull request #46 from CDKnightNASA/fix-45-term_filenames
685964d 
Fix #45 - null terminates src/dst filenames
@astrogeco astrogeco mentioned this issue Jul 1, 2020
Merged
@astrogeco astrogeco added the bug Something isn't working label Oct 1, 2020
@astrogeco astrogeco added this to the 3.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
2 participants
@CDKnightNASA @astrogeco