Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml #181

Merged
merged 14 commits into from
Dec 13, 2023
Merged

Add pyproject.toml #181

merged 14 commits into from
Dec 13, 2023

Conversation

thomas-bc
Copy link
Contributor

@thomas-bc thomas-bc commented Dec 6, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) nasa/fprime#1995
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

  • Add pyproject.toml
  • Strip setup.py from old config
  • Update publishing workflow to use trusted publishers mechanism

Rationale

Conform to PEP517, 518 et al. Modernize our Python setup so as not to be left behind. Potentially help with Python 3.12 support

Testing/Review Recommendations

Tested in branch with test.pypi.org:
https://github.com/fprime-community/fprime-tools/actions/runs/7119122735
https://test.pypi.org/project/fprime-tools/0.0.1a2/

TODO:

  • sanity check that this switch won't break other external things?
  • alpha release and let CI fly

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment in-line. Additionally setup.py should now look like:

from setuptools import setup

setup()

As noted for backwards compatibility here: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

.github/workflows/publish.yml Outdated Show resolved Hide resolved
LeStarch
LeStarch previously approved these changes Dec 7, 2023
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PY 12? but not a blocker.

@LeStarch LeStarch merged commit c91bd87 into devel Dec 13, 2023
26 checks passed
@thomas-bc thomas-bc deleted the pyproject-toml branch December 20, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants