Set disabled items to use disabled property #7342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New CSS for `aria-disabled = true` property. - Changed multiple items to use aria-disabled instead of .disabled, including: - Action menu - Super menu - Notebook drag area - Tree item style modded to only italicize when is-navigated and is being edited. - Create button sets itself to `disabled` when the editor is in use.
Current Playwright Test Results Summary✅ 172 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/05/2024 12:35:07am UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Tabs View Renders tabbed elements
Retry 1 • Initial Attempt |
0% (0)0 / 51 runsfailed over last 7 days |
49.02% (25)25 / 51 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
1.67% (1)1 / 60 runfailed over last 7 days |
21.67% (13)13 / 60 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Condition Set CRUD Operations on @localStorage Condition set object properties persist in main view and inspector @localStorage
Retry 1 • Initial Attempt |
5.66% (3)3 / 53 runsfailed over last 7 days |
9.43% (5)5 / 53 runsflaked over last 7 days |
|
Condition Set CRUD Operations on @localStorage condition set object can be modified on @localStorage
Retry 1 • Initial Attempt |
-11.11% (-5)-5 / 45 runsfailed over last 7 days |
11.11% (5)5 / 45 runsflaked over last 7 days |
|
Condition Set CRUD Operations on @localStorage condition set object can be deleted by Search Tree Actions menu on @localStorage
Retry 1 • Initial Attempt |
-11.11% (-5)-5 / 45 runsfailed over last 7 days |
11.11% (5)5 / 45 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
1.85% (1)1 / 54 runfailed over last 7 days |
53.70% (29)29 / 54 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
1.69% (1)1 / 59 runfailed over last 7 days |
23.73% (14)14 / 59 runsflaked over last 7 days |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7342 +/- ##
==========================================
+ Coverage 55.89% 55.97% +0.08%
==========================================
Files 662 662
Lines 26394 26465 +71
Branches 2563 2563
==========================================
+ Hits 14753 14814 +61
- Misses 10927 10938 +11
+ Partials 714 713 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
unlikelyzero
reviewed
Jan 5, 2024
…nto fix-disabled-7322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7322
aria-disabled = trueproperty..disabled, including:Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist