Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Add Global Search to Mobile #7477

Merged
merged 22 commits into from
Feb 21, 2024
Merged

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Feb 5, 2024

Closes #7349 #6530

Describe your changes:

  • Adds status area back into mobile with some modifications
  • Adds grand search into status area
  • Makes changes to grand search's actions to be mobile-friendly.
  • In mobile portrait mode, the search bar is collapsed until a user clicks on it. This PR includes an animation that expands the search bar when the search is active.
  • Adds the capability to test these changes via [e2e] Create a minimal mobile suite #6530

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bbabf9) 55.38% compared to head (f762f38) 55.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7477      +/-   ##
==========================================
- Coverage   55.38%   55.09%   -0.29%     
==========================================
  Files         671      671              
  Lines       27013    27013              
  Branches     2633     2633              
==========================================
- Hits        14961    14884      -77     
- Misses      11328    11405      +77     
  Partials      724      724              
Flag Coverage Δ
e2e-full 21.63% <ø> (-19.47%) ⬇️
e2e-stable 59.45% <ø> (+0.05%) ⬆️
unit 48.40% <100.00%> (-0.04%) ⬇️
Files Coverage Δ
src/ui/layout/search/SearchResultsDropDown.vue 76.47% <100.00%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbabf9...f762f38. Read the comment docs.

@ozyx
Copy link
Contributor

ozyx commented Feb 6, 2024

@rukmini-bose we might need to rebase this. we can sync some time this week and get it fixed

@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 9, 2024
@unlikelyzero unlikelyzero requested a review from ozyx February 15, 2024 00:24
@ozyx ozyx force-pushed the status-area-redesign branch 2 times, most recently from ffab21b to 7ffd4e7 Compare February 15, 2024 20:49
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and LGTM. I want us to set the focus to the input when the user expands the search input by tapping on the magnify glass (so they don't have to tap twice), but will follow that up with a new issue.

@@ -260,8 +285,11 @@ workflows:
- e2e-test:
name: e2e-stable
suite: stable
- e2e-mobile
- mem-test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is broken

@unlikelyzero unlikelyzero added the type:feature Feature. Required intentional design label Feb 21, 2024
@unlikelyzero unlikelyzero merged commit 6393a77 into master Feb 21, 2024
19 of 22 checks passed
@unlikelyzero unlikelyzero deleted the status-area-redesign branch February 21, 2024 23:29
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Feb 22, 2024
@@ -27,6 +27,11 @@
aria-label="Search Results Dropdown"
class="c-gsearch__dropdown"
>
<button
aria-label="Close"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this button for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile Support] Global Search is missing and needs redesign for mobile
4 participants