-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure stacked plots show cumulative legend #7481
Ensure stacked plots show cumulative legend #7481
Conversation
…show-legend-per-plot-is-broken
…show-legend-per-plot-is-broken
…panding-when-requested' into 7386-stacked-plots-show-legend-per-plot-is-broken
Note, composables would be really good here, but I'm a bit reluctant to refactor heavily in a bug fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7403-plot-legends-legends-not-expanding-when-requested #7481 +/- ##
==========================================================================================
- Coverage 55.37% 48.93% -6.44%
==========================================================================================
Files 671 428 -243
Lines 26935 13329 -13606
Branches 2614 0 -2614
==========================================================================================
- Hits 14914 6522 -8392
+ Misses 11305 6807 -4498
+ Partials 716 0 -716
*This pull request uses carry forward flags. Click here to find out more. see 501 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look and work great, just a small suggestion
9799b04
into
7403-plot-legends-legends-not-expanding-when-requested
* expanded legend showing, but malformed * fix legends * add e2e test and aria labels for controls * fix tests * remove focused test * make plot legend items dynamic * expand legend immediately when changing default * Ensure stacked plots show cumulative legend (#7481) * simplify config loading logic * wip * fixed stacked plot legend issue * fix legend * remove console.debugs * remove extraneous prop * add test * fix legend * use props
Closes #7403
Describe your changes:
Listen to series models in the legend, and hide options that don't make sense if the cumulative legend isn't being used.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist