Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collapse to Recent Objects #7502

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Add Collapse to Recent Objects #7502

merged 7 commits into from
Feb 21, 2024

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Feb 13, 2024

Closes #7491

Describe your changes:

  • Add class to Recents such that it is horizontally collapsable
  • Fix styling of collapse action such that it is consistent with other collapses seen in Object Tree and Inspector
  • Add Aria Label and Title that is distinct from Tree and Inspector.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5894c66) 55.37% compared to head (c3190f4) 55.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7502   +/-   ##
=======================================
  Coverage   55.37%   55.38%           
=======================================
  Files         671      671           
  Lines       27012    27013    +1     
  Branches     2632     2633    +1     
=======================================
+ Hits        14959    14960    +1     
+ Misses      11330    11329    -1     
- Partials      723      724    +1     
Flag Coverage Δ *Carryforward flag
e2e-full 41.41% <ø> (+0.30%) ⬆️ Carriedforward from 3f63820
e2e-stable 59.38% <ø> (+<0.01%) ⬆️
unit 48.40% <42.85%> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/ui/layout/PaneContainer.vue 48.23% <100.00%> (-0.58%) ⬇️
src/ui/layout/AppLayout.vue 20.40% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5894c66...c3190f4. Read the comment docs.

@ozyx
Copy link
Contributor

ozyx commented Feb 14, 2024

We should add some visual tests (or modify existing tests) to cover Recent Objects, I'm not sure if we have any

<pane
handle="before"
label="Recently Viewed"
:persist-position="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to be bound to anything as it's constant

Suggested change
:persist-position="true"
persist-position="true"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was wrong about this. If we're passing a boolean, we need the :v-bind otherwise it gets passed as a string. Just Vue 3 Things

@rukmini-bose rukmini-bose requested a review from ozyx February 20, 2024 17:50
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 20, 2024
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work, this looks great. In a separate PR, we should update the default starting position of the panel to be higher for visibility.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 21, 2024
@ozyx ozyx enabled auto-merge (squash) February 21, 2024 21:24
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 21, 2024
@ozyx ozyx merged commit f18d1d2 into master Feb 21, 2024
17 of 21 checks passed
@ozyx ozyx deleted the collapse-recents branch February 21, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants